ACK: [PULL REQUEST][focal/linux-azure] Fix race on per-CQ variable napi work_done

Bartlomiej Zolnierkiewicz bartlomiej.zolnierkiewicz at canonical.com
Thu Feb 9 16:09:03 UTC 2023


Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>

On Thu, Jan 19, 2023 at 4:06 PM Tim Gardner <tim.gardner at canonical.com> wrote:
>
> SRU Justification
>
> https://bugs.launchpad.net/bugs/2003353
>
> [Impact]
>
> This patch [1]1 is requested by MSFT Linux Systems Group to fix a race
> condition that can cause a panic in napi_iperf().
>
> [1] -
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=18010ff776fa42340efc428b3ea6d19b3e7c7b21
>
> A number of prerequisite patches are required. v5.15.83 contains this
> patch, however v5.19 stable does not.
>
> [Test Case]
>
> MSFT tested and approved, "Please merge in both the kernels, LSG
> finished the validation".
>
> [Where things could go wrong]
>
> Test results are good. Regression potential seems low.
>
> [Other Info]
>
> SF: #00350135
>
> ----------------------------------------------------------------
>
> The following changes since commit f02acc2610ccac22acaa1713e8f767e7504fe72d:
>
>    UBUNTU: Ubuntu-azure-5.4.0-1102.108 (2023-01-17 08:58:09 -0700)
>
> are available in the Git repository at:
>
>    git://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/focal
> focal-azure-Fix-race-on-per-CQ-variable-napi_iperf-panic-fix-sf00350135
>
> for you to fetch changes up to 061b7c9da6bc794e26802178cf2edfe38087f52c:
>
>    net: mana: Fix race on per-CQ variable napi work_done (2023-01-19
> 08:01:48 -0700)
>
> ----------------------------------------------------------------
> Christophe JAILLET (1):
>        net: mana: Fix a memory leak in an error handling path in
> 'mana_create_txq()'
>
> Gustavo A. R. Silva (1):
>        net: mana: Use struct_size() in kzalloc()
>
> Haiyang Zhang (5):
>        net: mana: Move NAPI from EQ to CQ
>        net: mana: Add support for EQ sharing
>        net: mana: Add WARN_ON_ONCE in case of CQE read overflow
>        net: mana: Fix error handling in mana_create_rxq()
>        net: mana: Fix race on per-CQ variable napi work_done
>
> Len Baker (1):
>        net: mana: Prefer struct_size over open coded arithmetic
>
>   drivers/net/ethernet/microsoft/mana/gdma.h       |  39 +++++++++------
>   drivers/net/ethernet/microsoft/mana/gdma_main.c  |  88
> +++++++++++-----------------------
>   drivers/net/ethernet/microsoft/mana/hw_channel.c |   6 +--
>   drivers/net/ethernet/microsoft/mana/mana.h       |  29 +++++++-----
>   drivers/net/ethernet/microsoft/mana/mana_en.c    | 183
> +++++++++++++++++++++++++++++++++++++++++------------------------------
>   5 files changed, 176 insertions(+), 169 deletions(-)
> --
> -----------
> Tim Gardner
> Canonical, Inc
>



More information about the kernel-team mailing list