NACK: [SRU][Lunar][PATCH 0/3] Fix udpgro_frglist.sh kernel selftest

Andrei Gherzan andrei.gherzan at canonical.com
Thu Feb 9 11:29:14 UTC 2023


On 23/02/08 06:14PM, Andrei Gherzan wrote:
> Buglink: https://bugs.launchpad.net/bugs/1996536
> Buglink: https://bugs.launchpad.net/bugs/2000708
> 
> SRU Justification:
> 
> [Impact]
> 
> * The udpgro_frglist.sh was failing due to not being able to find a
> dependency: nat6to4. This dependency was broken upstream due to
> where it gets compiled but also disabled by us in lp:1996536 for lack of
> CC support.
> 
> [Fix]
> 
> * This series backports a couple of patches fixing the expected location
> of nat6to4 for udpgro_frglist.sh and also adding CC support for nat6to4.
> * All patches apply cleanly (with some fuzz) except
> 3c107f36db061603bee7564fbd6388b1f1879fd3 which requires minimum context
> changes due to tests changes in the net Makefile.
> 
> [Test Plan]
> 
> * These patches were tested by building the kernel, the tests
> required for udpgro_frglist.sh and running the test successfully in a
> clean VM.
> 
> [Where problems could occur]
> 
> * The regression can be considered as low, since it would affect only
> some tests.
> 
> Björn Töpel (2):
>   selftests: net: Add cross-compilation support for BPF programs
>   selftests: net: Fix O=dir builds
> 
> Hangbin Liu (1):
>   selftests/net: mv bpf/nat6to4.c to net folder
> 
>  tools/testing/selftests/net/Makefile          | 51 ++++++++++++++++++-
>  tools/testing/selftests/net/bpf/Makefile      | 45 ++++++++++++++--
>  .../testing/selftests/net/{bpf => }/nat6to4.c |  0
>  tools/testing/selftests/net/udpgro_frglist.sh |  8 +--
>  4 files changed, 94 insertions(+), 10 deletions(-)
>  rename tools/testing/selftests/net/{bpf => }/nat6to4.c (100%)

Sending a v2 due due a dangling line from a git conflict in one of the
patches.

-- 
Andrei Gherzan



More information about the kernel-team mailing list