[F/J][SRU][PATCH 0/1] Fix return code for net/fcnal-test.sh test
Po-Hsu Lin
po-hsu.lin at canonical.com
Thu Feb 9 08:28:27 UTC 2023
[Impact]
The net/fcnal-test.sh on F/J won't return a non-zero value even with
some sub test cases failed, here is an example on Jammy:
# Tests passed: 857
# Tests failed: 5
ok 1 selftests: net: fcnal-test.sh
Therefore it's marked as PASSED on our report and making it difficult
to spot these failures:
# With VRF
# SYSCTL: net.ipv4.raw_l3mdev_accept=1
# TEST: ping local, VRF bind - VRF IP [FAIL]
# TEST: ping local, device bind - ns-A IP [FAIL]
# SYSCTL: net.ipv4.ping_group_range=0 2147483647
# SYSCTL: net.ipv4.raw_l3mdev_accept=1
# TEST: ping local, VRF bind - VRF IP [FAIL]
# TEST: ping local, device bind - ns-A IP [FAIL]
# With VRF
# SYSCTL: net.ipv4.raw_l3mdev_accept=1
# SYSCTL: net.ipv4.ping_group_range=0 2147483647
# SYSCTL: net.ipv4.raw_l3mdev_accept=1
# TEST: ping out, vrf device+address bind - ns-B IPv6 LLA [FAIL]
[Fix]
* 0f8a3b48f9 selftests: net/fcnal-test.sh: add exit code
This patch can be cherry-picked into Focal and Jammy kernel.
We don't have this test in Bionic, and this patch has already landed
on Kinetic and OEM-5.17
[Test]
Run the patched test, the return value will be 1 whenever the number
of failed test cases is not 0.
[Where problems could occur]
Change limited to testing tools, but we're expected to see new failures
in Jammy. With bug 2006391 fixed later on, we will see failures
reported in F/K as well.
Li Zhijian (1):
selftests: net/fcnal-test.sh: add exit code
tools/testing/selftests/net/fcnal-test.sh | 8 ++++++++
1 file changed, 8 insertions(+)
--
2.7.4
More information about the kernel-team
mailing list