NACK[J:HWE-5.17]/Cmnt: [J/hwe-5.17][OEM-5.17][K][SRU][PATCH 0/1] Fix cleanup in net/arp_ndisc_evict_nocarrier test

[Po-Hsu Lin]

On Wed, Feb 8, 2023 at 4:26 PM Stefan Bader <stefan.bader at canonical.com> wrote:
>
> On 07.02.23 11:15, Po-Hsu Lin wrote:
> > [Impact]
> > In selftests: net: arp_ndisc_evict_nocarrier.sh, even all of the
> > sub-tests from this script have passed, the overall test result
> > is still a fail.
> >
> >    # selftests: net: arp_ndisc_evict_nocarrier.sh
> >    # run arp_evict_nocarrier=1 test
> >    # ok
> >    # run arp_evict_nocarrier=0 test
> >    # ok
> >    # run all.arp_evict_nocarrier=0 test
> >    # ok
> >    # run ndisc_evict_nocarrier=1 test
> >    # ok
> >    # run ndisc_evict_nocarrier=0 test
> >    # ok
> >    # run all.ndisc_evict_nocarrier=0 test
> >    # ok
> >    not ok 1 selftests: net: arp_ndisc_evict_nocarrier.sh # exit=255
> >
> > This is caused by the cleanup() in the script, as it's trying to
> > access a non-existing file.
> >
> > [Fix]
> > * 9c4d7f45d6 selftests: net: fix cleanup_v6() for arp_ndisc_evict_nocarrier
> >
> > This patch can be cherry-picked into all affected kernels.
> >
> > [Test]
> > Run the patched test and the test will pass.
> >
> > [Where problems could occur]
> > Change limited to testing tools, no impact to real kernel function
> > or test performances.
> >
> > Po-Hsu Lin (1):
> >    selftests: net: fix cleanup_v6() for arp_ndisc_evict_nocarrier
> >
> >   tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> To clarify what got discussed in other channels: hwe-5.17 is being phased out as
> oem-5.17 is now its sole user and then its just added complexity to have
> hwe-5.17 around. This got applied to oem-5.17 by now, so considering the
> submission completed.

Hi Stefan,

the submission is completed for 5.17 kernel, we still need this for Kinetic.

Thanks
Sam

>
> -Stefan
>