ACK: [SRU][Kinetic][PATCH 0/3] Fix udpgro_frglist.sh kernel selftest

Kamal Mostafa kamal at canonical.com
Wed Feb 8 20:07:13 UTC 2023


LGTM.  Thanks for addressing this, Andrei.

Acked-by: Kamal Mostafa <kamal at canonical.com>

 -Kamal

On Wed, Feb 8, 2023 at 10:14 AM Andrei Gherzan <andrei.gherzan at canonical.com>
wrote:

> Buglink: https://bugs.launchpad.net/bugs/1996536
> Buglink: https://bugs.launchpad.net/bugs/2000708
>
> SRU Justification:
>
> [Impact]
>
> * The udpgro_frglist.sh was failing due to not being able to find a
> dependency: nat6to4. This dependency was broken upstream due to
> where it gets compiled but also disabled by us in lp:1996536 for lack of
> CC support.
>
> [Fix]
>
> * This series backports a couple of patches fixing the expected location
> of nat6to4 for udpgro_frglist.sh and also adding CC support for nat6to4.
> * All patches apply cleanly (with some fuzz) except
> 3c107f36db061603bee7564fbd6388b1f1879fd3 which requires minimum context
> changes due to tests changes in the net Makefile.
>
> [Test Plan]
>
> * These patches were tested by building the kernel, the tests
> required for udpgro_frglist.sh and running the test successfully in a
> clean VM.
>
> [Where problems could occur]
>
> * The regression can be considered as low, since it would affect only
> some tests.
>
> Björn Töpel (2):
>   selftests: net: Add cross-compilation support for BPF programs
>   selftests: net: Fix O=dir builds
>
> Hangbin Liu (1):
>   selftests/net: mv bpf/nat6to4.c to net folder
>
>  tools/testing/selftests/net/Makefile          | 50 ++++++++++++++++++-
>  tools/testing/selftests/net/bpf/Makefile      | 15 ------
>  .../testing/selftests/net/{bpf => }/nat6to4.c |  0
>  tools/testing/selftests/net/udpgro_frglist.sh |  8 +--
>  4 files changed, 52 insertions(+), 21 deletions(-)
>  delete mode 100644 tools/testing/selftests/net/bpf/Makefile
>  rename tools/testing/selftests/net/{bpf => }/nat6to4.c (100%)
>
> --
> 2.34.1
>
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230208/21a5f8cc/attachment.html>


More information about the kernel-team mailing list