[SRU][Jammy][Pull] Update Broadcom Emulex FC HBA lpfc driver to 14.2.0.5

[Tim Gardner]

On 2/6/23 4:35 PM, Jeff Lane wrote:
> BugLink: https://bugs.launchpad.net/bugs/1988711
> 
> [IMPACT/Justification]
> There are numerous bug fixes included in the more recent version of lpfc That
> Broadcom has asked to pull into Jammy and Kinetic to better support customers
> in the field who are using the GA kernel and cant or wont move to the HWE
> kernels.
> 
> The following changes since commit 5add9724af4d4e85f752de8a0df71082479c939d:
> 
>    UBUNTU: Ubuntu-5.15.0-66.73 (2023-02-03 15:04:39 +0100)
> 
> are available in the Git repository at:
> 
>    https://git.launchpad.net/~bladernr/ubuntu/+source/linux/+git/jammy lpfc-patches
> 
> for you to fetch changes up to 7e7f656dab5fd69c3dd03d8d46edcdf1514444ed:
> 
>    UBUNTU: Update Broadcom Emulex FC HBA lpfc driver to 14.2.0.5 (2023-02-06 17:33:40 -0500)
> 
> ----------------------------------------------------------------
> Jeff Lane (1):
>        UBUNTU: Update Broadcom Emulex FC HBA lpfc driver to 14.2.0.5
> 
>   drivers/nvme/host/fc.c             |   18 +
>   drivers/scsi/lpfc/Makefile         |    2 +-
>   drivers/scsi/lpfc/lpfc.h           |  215 ++-
>   drivers/scsi/lpfc/lpfc_attr.c      |  310 +---
>   drivers/scsi/lpfc/lpfc_bsg.c       |  726 ++-------
>   drivers/scsi/lpfc/lpfc_bsg.h       |   14 +-
>   drivers/scsi/lpfc/lpfc_crtn.h      |   37 +-
>   drivers/scsi/lpfc/lpfc_ct.c        |  696 ++++----
>   drivers/scsi/lpfc/lpfc_debugfs.c   |   11 +-
>   drivers/scsi/lpfc/lpfc_els.c       | 2177 ++++++++++++++-----------
>   drivers/scsi/lpfc/lpfc_hbadisc.c   |  380 +++--
>   drivers/scsi/lpfc/lpfc_hw.h        |  150 +-
>   drivers/scsi/lpfc/lpfc_hw4.h       |   56 +-
>   drivers/scsi/lpfc/lpfc_ids.h       |   34 +-
>   drivers/scsi/lpfc/lpfc_init.c      |  453 ++++--
>   drivers/scsi/lpfc/lpfc_logmsg.h    |    2 +-
>   drivers/scsi/lpfc/lpfc_mbox.c      |  205 ++-
>   drivers/scsi/lpfc/lpfc_nportdisc.c |  183 ++-
>   drivers/scsi/lpfc/lpfc_nvme.c      |  199 ++-
>   drivers/scsi/lpfc/lpfc_nvme.h      |    8 +-
>   drivers/scsi/lpfc/lpfc_nvmet.c     |  206 +--
>   drivers/scsi/lpfc/lpfc_scsi.c      |  874 +++-------
>   drivers/scsi/lpfc/lpfc_sli.c       | 3127 +++++++++++++++++-------------------
>   drivers/scsi/lpfc/lpfc_sli.h       |   60 +-
>   drivers/scsi/lpfc/lpfc_sli4.h      |    5 +-
>   drivers/scsi/lpfc/lpfc_version.h   |    6 +-
>   drivers/scsi/lpfc/lpfc_vmid.c      |  288 ++++
>   drivers/scsi/lpfc/lpfc_vport.c     |   31 +-
>   28 files changed, 5272 insertions(+), 5201 deletions(-)
>   create mode 100644 drivers/scsi/lpfc/lpfc_vmid.c
> 

At first I thought there must be a mistake because I only found 1 patch 
in your pull request. But, indeed, there really is only one giant patch. 
Is this really the best way ? If you want to bisect problems with this 
driver in the future you're gonna have a tough time because there is no 
patch granularity. Plus, a patch this size is basically unreviewable. I 
would much prefer individual cherry-picks and backport commits.

rtg
-- 
-----------
Tim Gardner
Canonical, Inc