[OEM-5.17][K][SRU][PATCH 0/1] Improve arp_ndisc_evict_nocarrier.sh test result processing

Po-Hsu Lin po-hsu.lin at canonical.com
Wed Feb 8 05:02:45 UTC 2023


[Impact]
The arp_ndisc_evict_nocarrier.sh in selftests/net didn't pass a proper
return value for failed test cases. Thus we might get false negatives
if the last command runs successfully.

[Fix]
* 1856628baa selftests: net: return non-zero for failures reported in
arp_ndisc_evict_nocarrier

This patch can be cherry-picked into affected kernels. Lunar has been
patched already. J-hwe-5.17 will be deprecated thus it will be skipped.

[Test]
Run the patched test, this should not cause any regression as sub
tests are good with our kernels (except there is a cleanup issue in
bug 1968310)

One can deliberately fail a test by hijacking the if statement for the
return value check to make sure this patch is working as expected.

[Where problems could occur]
This patch improves the result interpretation, we might see new
failures being reported.

Po-Hsu Lin (1):
  selftests: net: return non-zero for failures reported in
    arp_ndisc_evict_nocarrier

 tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

-- 
2.7.4




More information about the kernel-team mailing list