ACK: [SRU] [L/M/N] [PATCH 0/1] Avoid using damage rectangle under hardware rotation mode when PSR is enabled

Yuxuan Luo yuxuan.luo at canonical.com
Mon Dec 11 19:59:26 UTC 2023


Acked-by: Yuxuan Luo <yuxuan.luo at canonical.com>

On 12/8/23 11:46, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2045958
>
> [Impact]
> When hardware rotation feature is used by compositor, the clip damage on
> cursor plane causes screen glitches on AMD platforms with PSR panel.
>
> [Fix]
> Disable clip damage when hardware rotation is used.
>
> [Test]
> With the patch applied, the issue can't be observed when the screen is
> rotated 180 degree.
> 90 and 270 degrees are unaffected since no compositor is using hardware
> rotation for those two angles.
>
> [Where problems could occur]
> The power consumption in theory will higher for 180 degree rotation
> because now the full screen may need to be redrawn when cursor moves.
>
> Hamza Mahfooz (1):
>    drm/amd/display: fix hw rotated modes when PSR-SU is enabled
>
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c    |  3 +++
>   drivers/gpu/drm/amd/display/dc/dc_hw_types.h         |  1 +
>   .../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c    |  3 ++-
>   drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c    | 12 ++++++++++--
>   4 files changed, 16 insertions(+), 3 deletions(-)
>



More information about the kernel-team mailing list