ACK/Cmnt: [SRU][J:linux-bluefield][PATCH v1 0/1] mlxbf-bootctl: fails to report info about cards using dev keys

[Andrei Gherzan]

On 23/12/07 07:23PM, Manuel Diewald wrote:
> On Thu, Dec 07, 2023 at 12:06:37PM -0500, David Thompson wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2045919
> > 
> > SRU Justification:
> > 
> > [Impact]
> > 
> > There is a gap in the mlxbf-bootctl driver logic, resulting in failure to
> > report when a secure boot enabled card is using development keys. The program
> > will instead report lifecycle state as "GA Secured" which is misleading.
> > 
> > [Fix]
> > 
> > Bring in the following upstream commit from linux-next:
> >   "mlxbf-bootctl: correctly identify secure boot with development keys"
> > 
> > [Test Case]
> > 
> > Enable secure boot on a BF3 card that is using development keys
> > Login as root on BF3
> > Run the command "mlxbf-bootctl"
> > Verify that the "lifecycle state" row shows "Secured (development)"
> > 
> > [Regression Potential]
> > 
> > Low risk change, cherry pick of upstream approved commit
> > 
> > David Thompson (1):
> >   mlxbf-bootctl: correctly identify secure boot with development keys
> > 
> >  drivers/platform/mellanox/mlxbf-bootctl.c | 39 +++++++++++++++--------
> >  1 file changed, 26 insertions(+), 13 deletions(-)
> > 
> > -- 
> > 2.30.1
> > 
> > 
> > -- 
> > kernel-team mailing list
> > kernel-team at lists.ubuntu.com
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team
> 
> No series to target is nominated (Jammy?) in the LP bug.

The patch looks good but +1 for Manuel's comment.

Acked-by: Andrei Gherzan <andrei.gherzan at canonical.com>

-- 
Andrei Gherzan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20231211/9ea1da5b/attachment.sig>