NACK: [L][SRU][PATCH 0/1] UBUNTU: [Packaging] drop references to is_rust_module.sh

[Po-Hsu Lin]

On Tue, Dec 5, 2023 at 5:58 PM Roxana Nicolescu
<roxana.nicolescu at canonical.com> wrote:
>
>
> On 05/12/2023 10:11, Po-Hsu Lin wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2045636
> >
> > [Impact]
> > The script/is_rust_module.sh has been removed with commit "UBUNTU:
> > SAUCE: scripts: rust: drop is_rust_module.sh" (LP: #2007654).
> > But the debian.master/reconstruct is not updated for this.
> >
> > Consequently we will see this error message when running "fakeroot
> > debian/rules clean" command:
> >
> > chmod: cannot access 'scripts/is_rust_module.sh': No such file or directory
> >
> > We didn't notice this as this is not a show-stopper.
> >
> > [Fix]
> > Remove corresponding lines from debian.master/reconstruct.
> >
> > We already have this issue fixed in Mantic+.
> >
> > [Test Plan]
> > Run "fakeroot debian/rules clean" with the patched kernel tree and
> > this error message should not exist anymore.
> >
> > [Where problems could occur]
> > Removing command line operation on a non-existing file, this should
> > not cause any regression.
> >
> > Po-Hsu Lin (1):
> >    UBUNTU: [Packaging] drop references to is_rust_module.sh
> >
> >   debian.master/reconstruct | 2 --
> >   1 file changed, 2 deletions(-)
> >
> >
> The entry `rm -f <script>` should be kept because in v6.2 the script is
> still there and it is needed when we build the source package,
> because in debian 1.0 we cannot remove files or change permission in the
> .diff.gz tarball.
> But indeed, `chmod` should not be there. I submitted a fix for
> #lp2045562 that should fix this.
> The reconstruct script will be regenerated when cranky close is run next
> time.
Thanks for the information,
In this case I will mark LP: #2045636 as a duplicate of LP: #2045562

>
> Roxana
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team