ACK: [SRU][J][PATCH v2 0/3] Fix failing net selftests

Thadeu Lima de Souza Cascardo cascardo at canonical.com
Fri Aug 25 10:57:09 UTC 2023


On Fri, Aug 25, 2023 at 08:36:13AM +0200, Roxana Nicolescu wrote:
[...] 
> Let's keep an eye on net:vrf-xfrm-tests.sh results next cycle since the
> algorithm has changed in the last patch.
> I personally find it strange to link 2 buglinks in the cover letter, but I
> also understand why these were submitted together.
> Maybe a "parent" bug would make sense in this case.
> 
> Acked-by: Roxana Nicolescu <roxana.nicolescu at canonical.com>

Though I think it is important to understand the end goal here and be able to
track its progress, I am not sure launchpad bugs have been used for that much.

In this particular case, it is about "Adjust tests that use crypto to work in
FIPS mode", and that task has been broken in subtasks, like "adjust TLS socket
tests", "adjust xfrm tests", etc.

So Magali created those two bugs for each of the subtasks and submitted them as
a single cover letter. That didn't get in the way of me reviewing them and
understand why they are for. The cover letter suits it fine. Our tooling even
manages commits having two BugLinks or a BugLink plus a CVE when producing
changelogs.

My points are: 1) let's not introduce further paperwork to get patches reviewed
and applied, Magali did a stelar job in her submission here, not only in
writing the cover letter, but all work that I believe was behind it (specially
testing).

2) If any tracking of tasks is necessary, we have different tools to deal with
that. Let's use them, but not let them meddle with how we submit and review
patches.

Cascardo.



More information about the kernel-team mailing list