ACK: [PATCH 0/4] [SRU][jammy:linux] Add fine-grained control for FAN(TFN) on Alderlake platforms.

Tim Gardner tim.gardner at canonical.com
Mon Aug 14 17:31:45 UTC 2023


On 8/14/23 11:00 AM, Philip Cox wrote:
> BugLink: https://bugs.launchpad.net/bugs/2031333
> 
> SRU Justification:
> 
> [Impact]
> Add a method to get fine-grained control for fans on Intel Alderlake platforms
> 
> 
> [Fix]
> Enable the fine graned fan control for Intel ADL platforms.
> 
> [Test Plan]
> Intel has tested this patch, and has upstreamed it in the 5.18.
> 
> I have built and tested this change on adl-s, adl-n, and adl-p platforms.
> 
> [Where problems could occur]
> The size of a couple members within the ACPI structs has changed sizes.  This brings the code in line with the ACPI spec, but if some callers (present or future) make assumptions on the size of these members, corruption can occur.
> 
> 
> Srinivas Pandruvada (4):
>    ACPI: fan: Separate file for attributes creation
>    ACPI: fan: Optimize struct acpi_fan_fif
>    ACPI: fan: Properly handle fine grain control
>    ACPI: fan: Add additional attributes for fine grain control
> 
>   drivers/acpi/Makefile              |   3 +
>   drivers/acpi/fan.h                 |  44 +++++++
>   drivers/acpi/fan_attr.c            | 137 ++++++++++++++++++++
>   drivers/acpi/{fan.c => fan_core.c} | 200 ++++++++++++-----------------
>   4 files changed, 268 insertions(+), 116 deletions(-)
>   create mode 100644 drivers/acpi/fan_attr.c
>   rename drivers/acpi/{fan.c => fan_core.c} (75%)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>
-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list