ACK/Cmnt: [Unstable/Lunar][PATCH] UBUNTU: [Packaging] Remove update-version-dkms

[Andrei Gherzan]

On 23/04/20 01:15PM, Juerg Haefliger wrote:
> It's a legacy script that doesn't do anthing since 2021 so finally
> remove it.
> 
> Fixes: 5cc78bf956c7 ("UBUNTU: [Packaging] switch to kernel-versions")
> Signed-off-by: Juerg Haefliger <juerg.haefliger at canonical.com>
> ---
>  update-version-dkms | 4 ----
>  1 file changed, 4 deletions(-)
>  delete mode 100755 update-version-dkms
> 
> diff --git a/update-version-dkms b/update-version-dkms
> deleted file mode 100755
> index a266fecc06f8..000000000000
> --- a/update-version-dkms
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -#!/bin/bash
> -
> -echo "EE: run update-dkms-versions after link-to-tracker" 1>&2
> -exit 1
> -- 
> 2.37.2

This looks good to me but I'm thinking, shouldn't this be a cranky thing
as opposed to having a in tree script? Also, if we end up dropping it,
we will need to also update the cranky docs to avoid confusion where the
script is not found[1].

[1] https://canonical-kteam-docs.readthedocs-hosted.com/en/latest/docs/kteam_tools/cranking-the-kernel.html#dkms-package-update-stage-update-dkms-versions

Acked-by: Andrei Gherzan <andrei.gherzan at canonical.com>

-- 
Andrei Gherzan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230421/d3ff7b58/attachment.sig>