[SRU J/K][PATCH V3 2/3] UBUNTU: [Config] Add arm64 option to CONFIG_HP_WATCHDOG

[Stefan Bader]

On 20.04.23 21:19, Michael Reed wrote:
> From: Michael Reed <Michael.Reed at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2008751
> 
> CONFIG_HP_WATCHDOG is used in module hpwdt.  A software monitoring watchdog
> and NMI handling driver. This driver will detect lockups and provide
> a stack trace. This is a driver that will only load on an HP ProLiant
> system with a minimum of iLO2 support.  This option allow it to build
> on arm64.
> 
> Signed-off-by: Michael Reed <Michael.Reed at canonical.com>
> ---
>   debian.master/config/annotations | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Does this really work? In J/K the annotations are just used for checks 
(and even those not necessarily enforce things. It might be ok as the 
arm64 side could have been unreachable and thus the option being part of 
config.common.ubuntu. This seems to be the case. So I guess it is ok. 
Would just be better if the change mentioned that it is already part of 
the config.common.ubuntu.

What I probably also would do is to re-order the config change to be the 
last of the set.

> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index a531e19a9288..480a7073f0c1 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -10465,7 +10465,7 @@ CONFIG_ITCO_WDT                                 policy<{'amd64': 'm'}>
>   CONFIG_ITCO_VENDOR_SUPPORT                      policy<{'amd64': 'y'}>
>   CONFIG_IT8712F_WDT                              policy<{'amd64': 'm'}>
>   CONFIG_IT87_WDT                                 policy<{'amd64': 'm'}>
> -CONFIG_HP_WATCHDOG                              policy<{'amd64': 'm'}>
> +CONFIG_HP_WATCHDOG                              policy<{'amd64': 'm', 'arm64': 'm'}>
>   CONFIG_HPWDT_NMI_DECODING                       policy<{'amd64': 'y'}>
>   CONFIG_KEMPLD_WDT                               policy<{'amd64': 'm', 'arm64': 'm', 'armhf': 'm', 'ppc64el': 'm'}>
>   CONFIG_SC1200_WDT                               policy<{'amd64': 'm'}>

-- 
- Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 44613 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230421/f9e241de/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20230421/f9e241de/attachment-0001.sig>