[SRU L, K, J, F, B][PATCH 0/1] UBUNTU: [Debian] autoreconstruct - fix restoration of execute permissions
Roxana Nicolescu
roxana.nicolescu at canonical.com
Thu Apr 6 17:49:04 UTC 2023
BugLink: http://bugs.launchpad.net/bugs/2015498
[Impact]
Debian source package diffs cannot represent that a file should be
executable. gen-auto-reconstruct detects when a commit adds a script
that is supposed to be invoked during the build and restores the
execute permissions in the reconstruct script by adding
`chmod +x $file`.
But, if a file removes its execute permission, this will change it
back. This happened in the last jammy release (version 5.15.0-70.77)
where a commit from upstream removed the execute permission for a
header file but then our scripts brought it back.
[Fix]
The script now checks if the permission was either added or removed
and adds either `cmod +x` or `chmod -x` in the reconstruct script.
[Test plan]
Easily tested with linux-jammy latest release where a rebase picked
this commit "treewide: fix up files incorrectly marked executable"
where `drivers/gpu/drm/vmwgfx/vmwgfx_msg_arm64.h` changed its
permission from 755 to 644 (execute permission were removed).
When debian packages are prepared, you'll notice the file has changed
its permission back to 755.
With this fix, permission should be the same, while all the other
scripts have kept their permissions.
[Regression potential]
Very low, it is a very small fix that has been tested in both scenarios:
1. when a file has execute permission
2. when a file removed its execute permission
Roxana Nicolescu (1):
UBUNTU: [Debian] autoreconstruct - fix restoration of execute permissions
debian/scripts/misc/gen-auto-reconstruct | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--
2.34.1
More information about the kernel-team
mailing list