ACK: [SRU][F:linux-bluefield][PATCH v2 0/1] net: sched: allow flower to match vxlan options

[Tony Duan]

Hi Bartlomiej,

d515d63cae2c ("net/mlx5e: Don't support encap rules with gbp option") is a separate bug fix for vxlan gbp option HW offload support in driver. It is needed to be submitted as well.

btw, there are another five follow up commits in upstream for fully supporting vxlan gbp HW offload support.
6ee44c518159 net/mlx5e: TC, Add support for VxLAN GBP encap/decap flows offload
bc9d003dc48c ip_tunnel: Preserve pointer const in ip_tunnel_info_opts
58de53c10258 net/mlx5e: Add helper for encap_info_equal for tunnels with options
c641e9279f35 vxlan: Expose helper vxlan_build_gbp_hdr
df5e87f16c33 vxlan: Remove unused argument from vxlan_build_gbp_hdr( ) and vxlan_build_gpe_hdr( )

Thank you,
Tony

-----Original Message-----
From: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com> 
Sent: Wednesday, April 5, 2023 6:41 PM
To: Tony Duan <yifeid at nvidia.com>
Cc: Ubuntu Kernel Team <kernel-team at lists.ubuntu.com>; Bodong Wang <bodong at nvidia.com>; Vladimir Sokolovsky <vlad at nvidia.com>; Thadeu Lima de Souza Cascardo <cascardo at canonical.com>; Dann Frazier <dann.frazier at canonical.com>
Subject: Re: ACK: [SRU][F:linux-bluefield][PATCH v2 0/1] net: sched: allow flower to match vxlan options

External email: Use caution opening links or attachments


Hi Tony,

While my ACK holds (as without this fix "ovs" won't even compile) I wonder whether the backport of the commit d515d63cae2c ("net/mlx5e:
Don't support encap rules with gbp option") shouldn't also be submitted as a follow-up?

--
Best regards,
Bartlomiej

On Wed, Apr 5, 2023 at 12:29 PM Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com> wrote:
>
> Acked-by: Bartlomiej Zolnierkiewicz 
> <bartlomiej.zolnierkiewicz at canonical.com>
>
> On Sat, Apr 1, 2023 at 1:36 AM Tony Duan <yifeid at nvidia.com> wrote:
> >
> > Buglink: https://bugs.launchpad.net/bugs/2013422
> >
> > SRU Justification:
> >
> > [Impact]
> >
> > * This patch is to allow matching gbp option in vxlan. Introduce vxlan support to avoid "ovs" compile error.
> >
> > [Fix]
> >
> > * cherry-pick d8f9dfae49ce4ffb772dc10dd6578dc815b34c12 d8f9dfae49ce 
> > net: sched: allow flower to match vxlan options
> >
> > [Test Plan]
> >
> > 1) Compile "ovs" project, build succesfully.
> > 2) VXLAN option can be used as match condition in tc. eg:
> >       # ip link add name vxlan0 type vxlan dstport 0 external
> >       # tc qdisc add dev vxlan0 ingress
> >       # tc filter add dev vxlan0 protocol ip parent ffff: \
> >           flower \
> >             enc_src_ip 10.0.99.192 \
> >             enc_dst_ip 10.0.99.193 \
> >             enc_key_id 11 \
> >             vxlan_opts 01020304/ffffffff \
> >             ip_proto udp \
> >             action mirred egress redirect dev eth0
> >         Check the action is correcttly filtered
> >
> > [Where problems could occur]
> >
> > * Compile "ovs" without this fix, the compiling fails.
> >
> > [Other Info]
> >
> > * nothing
> >
> > -v2:
> > * Remove "UBUNTU: " prefix since it is already in upstream
> >
> > *** BLURB HERE ***
> >
> > Xin Long (1):
> >   net: sched: allow flower to match vxlan options
> >
> >  include/uapi/linux/pkt_cls.h |  13 +++++
> >  net/sched/cls_flower.c       | 109 +++++++++++++++++++++++++++++++++++
> >  2 files changed, 122 insertions(+)
> >