NAK: [SRU][J:linux-bluefield][PATCH v2 0/2] mlxbf_gige: replace SAUCE patch for "clear MDIO gateway lock"

Tim Gardner tim.gardner at canonical.com
Thu Sep 29 16:54:09 UTC 2022


On 9/29/22 10:01, David Thompson wrote:
> BugLink: https://bugs.launchpad.net/bugs/1991151
> 
> SRU Justification:
> 
> [Impact]
> 
> The Jammy repo contains the following SAUCE patch:
>    UBUNTU: SAUCE: mlxbf_gige: clear MDIO gateway lock after read
> This patch is now in mainline Linux kernel, so the SAUCE patch
> can be reverted and replaced with the upstream commit SHA.
> 
> [Fix]
> 
> The fix requires two parts, the first of which is addressed by
> the revert of the SAUCE patch
>    8d2dbbd437a1 UBUNTU: SAUCE: mlxbf_gige: clear MDIO gateway lock after read
> The second part of the fix is the cherry pick of upstream
>    182447b12144 mlxbf_gige: clear MDIO gateway lock after read
> 
> [Test Case]
> 
> Boot platform and bring up "oob_net0" interface properly
> Test that network traffic works properly
> 
> [Regression Potential]
> 
> Low, as this logic is well tested.
> 
> [Other]
> 
> None
> 
> David Thompson (2):
>    UBUNTU: SAUCE: Revert "UBUNTU: SAUCE: mlxbf_gige: clear MDIO gateway lock after read"
>    mlxbf_gige: clear MDIO gateway lock after read
> 
> 

You're missing your signed-off-by in patch 2. When cherry picking 
patches use the '-s -x' options. For example,

git cherry-pick -s -x 182447b12144b7be9b63a273d27c5a11bd54960a
-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list