ACK+Cmnt: [SRU Bionic/Focal/Jammy/HWE-5.17] CVE-2022-3028

[Stefan Bader]

On 21.09.22 18:51, Cengiz Can wrote:
> On Wed, 2022-09-21 at 10:51 -0300, Thadeu Lima de Souza Cascardo wrote:
>> I think this could have been sent as a single patch as I believe it applies
>> cleanly on all trees.
> 
> Other than the context, they are identical.
> 
> I thought of doing that but couldn't be sure.
> 
> Noted for future patches.

This only works if they are really all cherry picks and this is more restricted 
going through the mailing list. Running git cherry-pick has more info contained 
in the repository and at times does context limitations without you knowing.

For that reason I would always suggest to work with format-patch and am when 
preparing patchsets. Start with the closest target kernel wrt upstream and then 
work backwards in time. As long as things apply with just "git am" this can be 
treated as cherry-pick. Sometimes it also works when providing -C2 to am. This 
reduces the required matching context and would also qualify as cherry-pick 
(just double check that things still get applied to the same places as before 
because reduced context may match a different place). It should then be 
mentioned in the cover email which series need -C2 so whomever applies things is 
warned.

If there is more (also context) adjustment needed, the patch should be 
considered a backport. Often one can then take the adjusted set for further 
steps back into older series. This way you can come up with the minimum of 
submissions for all series required. And at the same time avoid people running 
into problems when they try to apply the email submissions.

-Stefan
> 
> Thanks!
> 
>>
>> Acked-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220922/edfe6ba2/attachment.sig>