NAK: [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: mlxbf-pmc: Fix error when reading unprogrammed events

[Tim Gardner]

On 9/9/22 03:27, Shravan Kumar Ramani wrote:
> BugLink: https://bugs.launchpad.net/bugs/1989172
> 
> SRU Justification:
> 
> [Impact]
> When the counters are not programmed to monitor any events, reading the
> "event<n>" file results in the following error:
> cat: /sys/class/hwmon/hwmon0/smmu0/event0: Invalid argument
> This is misleading and instead needs to indicate that the counter is currently
> not enabled.
> 
> [Fix]
> * First, skip the check for whether the counter is enabled when reading the event
> info. If the counter is not enabled, it should return 0, which is the default
> value when coming out of reset.
> * 0 is not a valid event in most blocks as per the respective event lists, so
> add a "Disable" event to all the event lists.
> 
> [Test Case]
> Without the fix, reading any "event" file right after reset when the counters
> are not programmed should result in the following error:
> cat: /sys/class/hwmon/hwmon0/smmu0/event0: Invalid argument
> 
> With the fix, it should instead print:
> 0x0: DISABLE
> 
> [Regression Potential]
> Can be considered minimal
> 
> Shravan Kumar Ramani (1):
>    UBUNTU: SAUCE: mlxbf-pmc: Fix error when reading unprogrammed events
> 
>   drivers/platform/mellanox/mlxbf-pmc.c | 24 ++----------------------
>   drivers/platform/mellanox/mlxbf-pmc.h |  6 ++++++
>   2 files changed, 8 insertions(+), 22 deletions(-)
> 

You have an unrelated version change in this patch.

-- 
-----------
Tim Gardner
Canonical, Inc