ACKx2/Cmnt: [SRU J][PATCH 1/1] scsi: hisi_sas: Increase debugfs_dump_index after dump is completed

[Stefan Bader]

On 13.09.22 10:27, Ike Panhc wrote:
> From: Luo Jiaxing <luojiaxing at huawei.com>
> 
> BugLink: https://launchpad.net/bugs/1982070
> 
> The hisi_hba debugfs_dump_index member should increased after a dump
> insertion completed, and not before it has started, so fix the code to do
> so.
> 
> Link: https://lore.kernel.org/r/1629799260-120116-6-git-send-email-john.garry@huawei.com
> Signed-off-by: Luo Jiaxing <luojiaxing at huawei.com>
> Signed-off-by: John Garry <john.garry at huawei.com>
> Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>
> (cherry picked from commit 9aec5ffa6e39926cff1a6b576c815a9cee90e259)
> Signed-off-by: Ike Panhc <ike.pan at canonical.com>
Acked-by: Tim Gardner <tim.gardner at canonical.com>
Acked-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger at canonical.com>
> ---

Thanks for re-submitting. Since the change is simple enough let us carry forward 
the 2 acks already given on each piece.

-Stefan

>   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> index 1f5e0688c0c8..7bf84b096474 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
> @@ -3695,7 +3695,6 @@ static void debugfs_snapshot_regs_v3_hw(struct hisi_hba *hisi_hba)
>   
>   	do_div(timestamp, NSEC_PER_MSEC);
>   	hisi_hba->debugfs_timestamp[debugfs_dump_index] = timestamp;
> -	hisi_hba->debugfs_dump_index++;
>   
>   	debugfs_snapshot_prepare_v3_hw(hisi_hba);
>   
> @@ -3711,6 +3710,7 @@ static void debugfs_snapshot_regs_v3_hw(struct hisi_hba *hisi_hba)
>   	debugfs_create_files_v3_hw(hisi_hba);
>   
>   	debugfs_snapshot_restore_v3_hw(hisi_hba);
> +	hisi_hba->debugfs_dump_index++;
>   }
>   
>   static ssize_t debugfs_trigger_dump_v3_hw_write(struct file *file,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220913/afaee4e0/attachment.sig>