NACK/Cmnt: [PATCH 00/14] [SRU][K/linux-kvm][Config] Use annotations from debian.master

Tim Gardner tim.gardner at canonical.com
Thu Oct 27 15:37:28 UTC 2022


On 10/27/22 6:39 AM, Paolo Pisati wrote:
> On Thu, Oct 27, 2022 at 12:54 PM Stefan Bader
> <stefan.bader at canonical.com> wrote:
>>
>> My main concern is with the patches which change config. There is no explanation
>> in the commit message why this makes sense/is done. The initial approach of KVM
>> was a minimal kernel which quickly boots in a VM/cloud.
>> I know this all should have been done better that way when this thing was
>> created. But at least now with changing things to match master we should better
>> note down (and the best long-term place is the commit message) what these things
>> do and why we think this should be synced now.
> 
> Ack, i'll factor out the config changes and resend.

You should also set do_enforce_all=true in debian.kvm/rules.d/amd64.mk 
so that future config changes don't drift.
-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list