NACK/Cmnt: [PATCH 00/14] [SRU][K/linux-kvm][Config] Use annotations from debian.master

[Stefan Bader]

On 27.10.22 10:41, Paolo Pisati wrote:
> BugLink: https://bugs.launchpad.net/bugs/1994693
> 
> [Issue]
> 
> linux-kvm wasn't using annotations from debian.master, and that induced a
> skew in fundamental config options between main and kvm kernels.
> 
> [Fix]
> 
> The attached series (broken down in pieces to ease review) make linux-kvm use
> annotations from debian.master and override options that are meant to be
> different.
> 
> Must be applied on top of "[SRU][KINETIC linux-kvm][PATCH] UBUNTU: [Config]
> Update SQUASHFS configs" already posted on the mailing list.
> 
> [How to test]
> 
> Crank updateconfigs shouldn't report any check-config error afterward.
> 
> [Regression potential]
> 
> These five patches:
> 
>    UBUNTU: [Config] align IMA config with debian.master
>    UBUNTU: [Config] align UBSAN config with debian.master
>    UBUNTU: [Config] disable X86_KERNEL_IBT
>    UBUNTU: [Config] align LSM_MMAP_MIN_ADDR with master
>    UBUNTU: [Config] align LSM with master
> 
> are the only changes in kvm config, everything else is annotations fix up.
> 
> Paolo Pisati (14):
>    UBUNTU: [Config] align IMA config with debian.master
>    UBUNTU: annotations: include annotations from debian.master
>    UBUNTU: annotations: CONFIG_SND_SOC* policy is not available
>    UBUNTU: annotations: fix up disabled options in master but not
>      available in kvm
>    UBUNTU: annotations: fix up options built as module in master but not
>      available in kvm
>    UBUNTU: annotations: fix up options built-in in master but not
>      available in kvm
>    UBUNTU: [Config] align UBSAN config with debian.master
>    UBUNTU: annotations: fix up options built-in in master but disabled in
>      kvm
>    UBUNTU: annotations: fix up options built as module in master but
>      disabled in kvm
>    UBUNTU: annotations: fix up options built-in in master but built as
>      module in kvm
>    UBUNTU: [Config] disable X86_KERNEL_IBT
>    UBUNTU: annotations: fix up LATENCYTOP
>    UBUNTU: [Config] align LSM_MMAP_MIN_ADDR with master
>    UBUNTU: [Config] align LSM with master
> 
>   debian.kvm/config/annotations          | 61 ++++++++++++++++++++++++++
>   debian.kvm/config/config.common.ubuntu | 57 +++++++++++++++++++++---
>   2 files changed, 111 insertions(+), 7 deletions(-)
> 

First two complaints are more nitpick but anyway: this should at least include a 
pull request. Second, "K/linux-kvm" is bad because "/" is more commonly used to 
list all required pieces. Please use "K:linux-kvm" or the complete handle 
"kinetic:linux-kvm".

My main concern is with the patches which change config. There is no explanation 
in the commit message why this makes sense/is done. The initial approach of KVM 
was a minimal kernel which quickly boots in a VM/cloud.
I know this all should have been done better that way when this thing was 
created. But at least now with changing things to match master we should better 
note down (and the best long-term place is the commit message) what these things 
do and why we think this should be synced now.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20221027/fa73f8dd/attachment-0001.sig>