NAK: [SRU][J:linux-bluefield][Pull Request][v5] i2c-mlxbf.c: Sync up driver with upstreaming

Tim Gardner tim.gardner at canonical.com
Tue Oct 11 15:37:24 UTC 2022


On 10/11/22 8:48 AM, Asmaa Mnebhi wrote:
> This pull request (17 commits) includes reverting 8 i2c-mlxbf.c commits in
> Jammy linux-bluefield. Then it cherry-picks the i2c-mlxbf.c related commits
> from linux-next master branch.
> 
> BugLink: https://bugs.launchpad.net/bugs/1991551
> 
> This pull request page can be found at:
> 
> https://code.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield/+git/version-seeds-1/+merge/430923
> 
> Git repo can be found at:
> 
> git+ssh://asmaam@git.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield/+git/version-seeds-1 master-next
> 
> for you to fetch changes starting from commit 37634b05eba76be930565e343800e0f4587241ea
> 
> Revert "UBUNTU: SAUCE: i2c-mlxbf.c: Add driver version"
> 
> Signed-off-by: Asmaa Mnebhi <asmaa at nvidia.com>
> 
> Asmaa Mnebhi (17):
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: Add driver version"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: Support lock mechanism"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: support BlueField-3 SoC"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf: prevent stack overflow in
>      mlxbf_i2c_smbus_start_transaction()"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: incorrect base address passed
>      during io write"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: Add multi slave functionality"
>    Revert "UBUNTU: SAUNCE: i2c-mlxbf.c: remove IRQF_ONESHOT"
>    Revert "UBUNTU: SAUNCE: i2c-mlxbf.c: Fix frequency calculation"
>    i2c: mlxbf: incorrect base address passed during io write
>    i2c: mlxbf: prevent stack overflow in
>      mlxbf_i2c_smbus_start_transaction()
>    i2c: mlxbf: remove IRQF_ONESHOT
>    i2c: mlxbf: Fix frequency calculation
>    i2c: mlxbf: support lock mechanism
>    i2c: mlxbf: add multi slave functionality
>    i2c: mlxbf: support BlueField-3 SoC
>    i2c: mlxbf: remove device tree support
>    UBUNTU: SAUCE: i2c-mlxbf.c: Add driver version
> 
>   .../bindings/i2c/mellanox,i2c-mlxbf.yaml      |  99 ----------
>   MAINTAINERS                                   |   1 -
>   drivers/i2c/busses/i2c-mlxbf.c                | 175 +++++++++---------
>   3 files changed, 90 insertions(+), 185 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml
> 

Slow down and think about what you're doing. The current tip of 
jammy/linux-bluefield master-next is Ubuntu-bluefield-5.15.0-1008.10. 
Re-apply your patch set on top of that tag so that you can ensure there 
are no conflicts and save the maintainer some effort when these patches 
are applied for real. It also wouldn't hurt to re-do some testing to 
ensure that your patch set hasn't introduced any regressions.

rtg
-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list