NAK: [SRU][J:linux-bluefield][Pull Request][v4] i2c-mlxbf.c: Sync up driver with upstreaming

Asmaa Mnebhi asmaa at nvidia.com
Tue Oct 11 14:47:30 UTC 2022


Same issue as before. Provided wrong commit #

-----Original Message-----
From: Tim Gardner <tim.gardner at canonical.com> 
Sent: Tuesday, October 11, 2022 10:45 AM
To: Asmaa Mnebhi <asmaa at nvidia.com>; kernel-team at lists.ubuntu.com
Subject: NAK: [SRU][J:linux-bluefield][Pull Request][v4] i2c-mlxbf.c: Sync up driver with upstreaming

On 10/11/22 8:00 AM, Asmaa Mnebhi wrote:
> This pull request (17 commits) includes reverting 8 i2c-mlxbf.c 
> commits in Jammy linux-bluefield. Then it cherry-picks the i2c-mlxbf.c 
> related commits from linux-next master branch.
> 
> BugLink: 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs
> .launchpad.net%2Fbugs%2F1991551&data=05%7C01%7Casmaa%40nvidia.com%
> 7C25aa84d27dde413c56fd08daab972dc8%7C43083d15727340c1b7db39efd9ccc17a%
> 7C0%7C0%7C638010963038785780%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
> DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&
> sdata=pGZmNk59H7yb19XsE1lhe5cuMaAln8kWkNsbIsDTuZQ%3D&reserved=0
> 
> This pull request page can be found at:
> 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcode
> .launchpad.net%2F~asmaam%2Fubuntu%2F%2Bsource%2Flinux-bluefield%2F%2Bg
> it%2Fversion-seeds-1%2F%2Bmerge%2F430923&data=05%7C01%7Casmaa%40nv
> idia.com%7C25aa84d27dde413c56fd08daab972dc8%7C43083d15727340c1b7db39ef
> d9ccc17a%7C0%7C0%7C638010963038785780%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7
> C%7C&sdata=IMj9Cp9l7yZMhB0X3ho6qRd%2BZQji7g5kinWVPXXMKbQ%3D&re
> served=0
> 
> Git repo can be found at:
> 
> git+ssh://asmaam@git.launchpad.net/~asmaam/ubuntu/+source/linux-bluefi
> git+eld/+git/version-seeds-1 master-next
> 
> for you to fetch changes starting from commit 
> e6fce8d00a190bd30960c58ab2a0bd345e447c14
> 
> Revert "UBUNTU: SAUCE: i2c-mlxbf.c: Add driver version"
> 
> Signed-off-by: Asmaa Mnebhi <asmaa at nvidia.com>
> 
> Asmaa Mnebhi (17):
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: Add driver version"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: Support lock mechanism"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: support BlueField-3 SoC"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf: prevent stack overflow in
>      mlxbf_i2c_smbus_start_transaction()"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: incorrect base address passed
>      during io write"
>    Revert "UBUNTU: SAUCE: i2c-mlxbf.c: Add multi slave functionality"
>    Revert "UBUNTU: SAUNCE: i2c-mlxbf.c: remove IRQF_ONESHOT"
>    Revert "UBUNTU: SAUNCE: i2c-mlxbf.c: Fix frequency calculation"
>    i2c: mlxbf: incorrect base address passed during io write
>    i2c: mlxbf: prevent stack overflow in
>      mlxbf_i2c_smbus_start_transaction()
>    i2c: mlxbf: remove IRQF_ONESHOT
>    i2c: mlxbf: Fix frequency calculation
>    i2c: mlxbf: support lock mechanism
>    i2c: mlxbf: add multi slave functionality
>    i2c: mlxbf: support BlueField-3 SoC
>    i2c: mlxbf: remove device tree support
>    UBUNTU: SAUCE: i2c-mlxbf.c: Add driver version
> 
>   .../bindings/i2c/mellanox,i2c-mlxbf.yaml      |  99 ----------
>   MAINTAINERS                                   |   1 -
>   drivers/i2c/busses/i2c-mlxbf.c                | 175 +++++++++---------
>   3 files changed, 90 insertions(+), 185 deletions(-)
>   delete mode 100644 
> Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml
> 

You must rebase your patches on top of Ubuntu-bluefield-5.15.0-1008.10. 
Furthermore, the starting SHA1 in your pull request
(e6fce8d00a190bd30960c58ab2a0bd345e447c14) does not exist on your master-next branch.

rtg
--
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list