NAK: [PATCH 0/4][SRU][focal:linux] NFSv4.1: Don't rebind to the same source port when reconnecting to the server

[Tim Gardner]

On 11/23/22 2:32 PM, Khaled Elmously wrote:
> I was wrong about changing the behaviour of NFSv4.0 - it does appear
> to be kept unchanged, as per:
> 
> -       if (minorversion > 0 && proto == XPRT_TRANSPORT_TCP) +
> if (minorversion == 0) +               __set_bit(NFS_CS_REUSEPORT,
> &cl_init.init_flags); +       else if (proto == XPRT_TRANSPORT_TCP) 
> cl_init.nconnect = nconnect;
> 
> 
> 
> But you do appear to making a small change in the behaviour of
> NFSv3.x though, as per patches 2 and 3. It seems you needed patch 2
> only to be able to cleanly cherry-pick patch 3, but that ends up
> introducing the NFS_CS_DS flag to NFSv3.x clients.
> 
> Would it be safer to omit patch 2 entirely and skip the changes to
> fs/nfs/nfs3client.c from patch 3? It should have no effect on your
> final intended fix.
> 

You are correct, there is a subtle change in behavior with patch 2. Same 
with patch 3. I'll post a v2 with just patch 4 backported without these 
changes.

rtg
-- 
-----------
Tim Gardner
Canonical, Inc