ACK: [SRU][B/raspi2][PATCH] spi: spidev: Completely disable the spidev warning

Cory Todd cory.todd at canonical.com
Fri Nov 25 18:23:40 UTC 2022


On Thu, Nov 24, 2022 at 03:07:41PM +0100, Juerg Haefliger wrote:
> From: Phil Elwell <phil at raspberrypi.org>
> 
> BugLink: https://bugs.launchpad.net/bugs/1997763
> 
> An alternative strategy would be to use "rpi,spidev" instead, but that
> would require many Raspberry Pi Device Tree changes.
> 
> Signed-off-by: Phil Elwell <phil at raspberrypi.org>
> 
> (cherry picked from commit 8caac6a83b5f681602cbd084e5585b7ff14b1384 rpi-5.4.y)
> Signed-off-by: Juerg Haefliger <juerg.haefliger at canonical.com>
> ---
>  drivers/spi/spidev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
> index 4c47facd5551..bb8c83b2e6db 100644
> --- a/drivers/spi/spidev.c
> +++ b/drivers/spi/spidev.c
> @@ -733,7 +733,7 @@ static int spidev_probe(struct spi_device *spi)
>  	 * compatible string, it is a Linux implementation thing
>  	 * rather than a description of the hardware.
>  	 */
> -	WARN(spi->dev.of_node &&
> +	WARN(0 && spi->dev.of_node &&
>  	     of_device_is_compatible(spi->dev.of_node, "spidev"),
>  	     "%pOF: buggy DT: spidev listed directly in DT\n", spi->dev.of_node);
>  

Acked-by: Cory Todd <cory.todd at canonical.com>




More information about the kernel-team mailing list