[PATCH 0/3][SRU][OEM-6.0] Fix a race condition with AMD PMF and Thinkpad-ACPI

You-Sheng Yang vicamo.yang at canonical.com
Tue Nov 15 07:53:14 UTC 2022

From: "You-Sheng Yang (vicamo)" <vicamo.yang at canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1993242


Depending on module load order there is a possibility that the AMT mode
selected initially by PMF will be incorrect if thinkpad_acpi has loaded


To avoid this issue adjust the initialization order in the PMF driver.
Commit 22ee98cb696e ("platform/x86/amd/pmf: install notify handler after
acpi init") takes the work, but it depends on two more commits that were
tagged as fixes for commits landed in bug 1987670.

[Test Case]

1. blacklist both amd-pmf and thinkpad-acpi
2. load thinkpad-acpi first
3. Load amd-pmf with dynamic debugging enabled

[Where problems could occur]

The first two parts are trivial, and the third one may have to receive
tests to find out if it has some other interference due to the load

[Other Info]

AMD PMF targets oem-6.0 or above and has included in v6.1-rc1.

Shyam Sundar S K (3):
  platform/x86/amd/pmf: Fix undefined reference to platform_profile
  platform/x86/amd/pmf: Fix clang unused variable warning
  platform/x86/amd/pmf: install notify handler after acpi init

 drivers/platform/x86/amd/pmf/Kconfig     |  1 +
 drivers/platform/x86/amd/pmf/acpi.c      | 38 ++++++++++++++----------
 drivers/platform/x86/amd/pmf/auto-mode.c |  8 +++--
 drivers/platform/x86/amd/pmf/core.c      |  4 +++
 drivers/platform/x86/amd/pmf/pmf.h       |  5 ++--
 drivers/platform/x86/amd/pmf/sps.c       | 11 ++++---
 6 files changed, 43 insertions(+), 24 deletions(-)


More information about the kernel-team mailing list