ACK: [SRU][B][PATCH 0/1] Fix BUG scheduling while atomic in tg3 ethernet driver
Tim Gardner
tim.gardner at canonical.com
Wed Nov 9 15:19:34 UTC 2022
On 11/9/22 6:19 AM, Luke Nowakowski-Krijger wrote:
> BugLink: https://bugs.launchpad.net/bugs/1995870
>
> [Impact]
>
> There were BUG: scheduling while atomic: ip/1210/0x00000200 appearing
> on xenial/hwe with the tg3 ethernet driver when running on rumford instance.
> Probably some performace degradation as the driver was trying to sleep while
> holding a spinlock.
> There also was cluttering of the kernel log with stack traces.
>
> [Fix]
>
> Change usleep_range -> udelay which is safe to call from atomic
> contexts.
>
> [Test]
>
> Compile tested only. Should see this resolved in the next cycle on
> xenial/hwe rumford instance.
>
> [Where problems could occur]
>
> Not much regression potential as the correct delay call is now being
> called.
>
> Jonathan Toppins (1):
> tg3: prevent scheduling while atomic splat
>
> drivers/net/ethernet/broadcom/tg3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Tim Gardner <tim.gardner at canonical.com>
--
-----------
Tim Gardner
Canonical, Inc
More information about the kernel-team
mailing list