ACK/Cmnt: [SRU] [PULL] [Kinetic] Add cs35l41 firmware loading support

[Tim Gardner]

On 11/9/22 8:07 AM, Kai-Heng Feng wrote:
> On Wed, Nov 9, 2022 at 10:40 PM Tim Gardner <tim.gardner at canonical.com> wrote:
>>
>> On 11/9/22 5:03 AM, Kai-Heng Feng wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1995957
>>>
>>> [Impact]
>>> Speakers on some laptops are rather quiet even with max volume.
>>>
>>> [Fix]
>>> Loading firmware to make cs35l41 speaker amplifier really work.
>>>
>>> [Test]
>>> With the fix applied, the speaker has become really loud as intended.
>>>
>>> [Where problems could occur]
>>> Most commits are refactoring codes on both ASoC and HDA parts, so things
>>> can be missed.
>>>
>>> Other than that, the change is strictly limited to cs35l41, so the
>>> regression scope is rather narrow.
>>>
>>> ---
>>>
>>> The following changes since commit 8d9eb8d19b7c145e0e98f7eb68fd1f1582f9771d:
>>>
>>>     UBUNTU: [Packaging] Support arch-specific compilers in updateconfigs (2022-10-26 07:39:25 +0200)
>>>
>>> are available in the Git repository at:
>>>
>>>     https://git.launchpad.net/~kaihengfeng/+git/linux cs35l41-5.19
>>>
>>> for you to fetch changes up to 91d7ec43e0a215edd253ef417336415361ca2800:
>>>
>>>     UBUNTU: [Config] updateconfigs for SND_HDA_CS_DSP_CONTROLS (2022-11-09 13:56:05 +0800)
>>>
>>> ----------------------------------------------------------------
>>> Andy Shevchenko (4):
>>>         ALSA: hda: cs35l41: Don't dereference fwnode handle
>>>         ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations
>>>         ALSA: hda: cs35l41: Drop wrong use of ACPI_PTR()
>>>         ALSA: hda: cs35l41: Consolidate selections under SND_HDA_SCODEC_CS35L41
>>>
>>> Kai-Heng Feng (1):
>>>         UBUNTU: [Config] updateconfigs for SND_HDA_CS_DSP_CONTROLS
>>>
>>> Stefan Binding (16):
>>>         ASoC: cs35l41: Move cs35l41 exit hibernate function into shared code
>>>         ASoC: cs35l41: Add common cs35l41 enter hibernate function
>>>         ASoC: cs35l41: Do not print error when waking from hibernation
>>>         ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls
>>>         ALSA: hda: hda_cs_dsp_ctl: Add apis to write the controls directly
>>>         ALSA: hda: cs35l41: Save codec object inside component struct
>>>         ALSA: hda: cs35l41: Save Subsystem ID inside CS35L41 Driver
>>>         ALSA: hda: cs35l41: Support reading subsystem id from ACPI
>>>         ALSA: hda: cs35l41: Support multiple load paths for firmware
>>>         ALSA: hda: cs35l41: Support Speaker ID for laptops
>>>         ALSA: hda: cs35l41: Support Hibernation during Suspend
>>>         ALSA: hda: cs35l41: Read Speaker Calibration data from UEFI variables
>>>         ALSA: hda: hda_cs_dsp_ctl: Add fw id strings
>>>         ALSA: hda: cs35l41: Add defaulted values into dsp bypass config sequence
>>>         ALSA: hda: cs35l41: Support Firmware switching and reloading
>>>         ALSA: hda: cs35l41: Add module parameter to control firmware load
>>>
>>> Takashi Iwai (2):
>>>         Revert "ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations"
>>>         ALSA: hda/realtek: More robust component matching for CS35L41
>>>
>>> Vitaly Rodionov (1):
>>>         ALSA: hda: cs35l41: Add initial DSP support and firmware loading
>>>
>>>    MAINTAINERS                               |   1 +
>>>    debian.master/config/config.common.ubuntu |   1 +
>>>    include/sound/cs35l41.h                   |   7 +
>>>    sound/pci/hda/Kconfig                     |  12 +-
>>>    sound/pci/hda/Makefile                    |   2 +
>>>    sound/pci/hda/cs35l41_hda.c               | 885 +++++++++++++++++++++++++++++-
>>>    sound/pci/hda/cs35l41_hda.h               |  39 ++
>>>    sound/pci/hda/cs35l41_hda_i2c.c           |   9 +-
>>>    sound/pci/hda/cs35l41_hda_spi.c           |   9 +-
>>>    sound/pci/hda/hda_component.h             |   3 +
>>>    sound/pci/hda/hda_cs_dsp_ctl.c            | 240 ++++++++
>>>    sound/pci/hda/hda_cs_dsp_ctl.h            |  39 ++
>>>    sound/pci/hda/patch_realtek.c             |  88 ++-
>>>    sound/soc/codecs/cs35l41-lib.c            |  82 ++-
>>>    sound/soc/codecs/cs35l41.c                |  71 +--
>>>    15 files changed, 1373 insertions(+), 115 deletions(-)
>>>    create mode 100644 sound/pci/hda/hda_cs_dsp_ctl.c
>>>    create mode 100644 sound/pci/hda/hda_cs_dsp_ctl.h
>>>
>>
>> Please rebase against Ubuntu-azure-5.19.0-1010.11 as there is a conflict
>> with 'ALSA: hda/realtek: More robust component matching for CS35L41'
> 
> I don't think Ubuntu-azure need this at all. This is for generic kernel.
> 
> Kai-Heng
> 
>>
Acked-by: Tim Gardner <tim.gardner at canonical.com>

Oops, I've got Azure on the brain.
-- 
-----------
Tim Gardner
Canonical, Inc