ACK: [SRU][J:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: mlx-bootctl: support icm carveout eeprom region read/write

Tim Gardner tim.gardner at canonical.com
Tue Nov 8 19:16:02 UTC 2022


On 10/31/22 10:18 AM, Asmaa Mnebhi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1995296
> 
> SRU Justification:
> 
> [Impact]
> 
> The BlueField-3 ICM carveout feature will enable NIC FW to bypass the SMMU block
> to access DRAM memory. The amount of memory accessible by FW will be controlled by ARM.
> This patch enables setting the size of the large ICM carveout from
> userspace. The max size is 1TB, has a granularity of 128MB and will be passed
> and printed in hex. The size unit is MB.
> 
> [Fix]
> 
> * Support SMC calls to control the large ICM carveout size.
> 
> [Test Case]
> 
> * Only valid testing on BlueField-3 real hardware.
> * set the region size from sysfs and NIC FW will test that it has access to the entire region requested.
> 
> [Regression Potential]
> 
> * This code doesn't really have a negative impact on the functionality of the mlxbf-bootctl
>    driver itself but could be a risk for the overall boot if not used/tested properly.
> * memory region requested is too large, adn linux cannot boot as a result. The memory
>    allocated for the ICM carveout cannot be accessed by linux.
> * the icmc size is not passed properly to NIC FW
> 
> Asmaa Mnebhi (1):
>    UBUNTU: SAUCE: mlx-bootctl: support icm carveout eeprom region
>      read/write
> 
>   drivers/platform/mellanox/mlxbf-bootctl.c | 40 +++++++++++++++++++++++
>   drivers/platform/mellanox/mlxbf-bootctl.h |  9 +++++
>   2 files changed, 49 insertions(+)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>
-- 
-----------
Tim Gardner
Canonical, Inc




More information about the kernel-team mailing list