APPLIED[F/I]/cmnt: [Impish][OEM-5.14][SRU][PATCHv2 0/2] Fix kselftests/net/test_vxlan_under_vrf.sh

[Kleber Souza]

On 25.05.22 13:08, Po-Hsu Lin wrote:
> [Impact]
> test_vxlan_under_vrf.sh in the net category of ubuntu_kernel_selftests
> will fail on 5.13 kernel with:
> 
>    # selftests: net: test_vxlan_under_vrf.sh
>    # Checking HV connectivity [ OK ]
>    # Check VM connectivity through VXLAN (underlay in the default VRF) [FAIL]
>    not ok 1 selftests: net: test_vxlan_under_vrf.sh # exit=1
> 
> Note that this test is not failing on F-oem-5.14 but it's better to
> have corresponding patches applied to reduce the maintenance cost
> in the future.
> 
> [Fix]
> * e7e4785f selftests: net: test_vxlan_under_vrf: fix HV connectivity test
> * b50d3b46 selftests: test_vxlan_under_vrf: Fix broken test case
> 
> Only I-5.13 and F-oem-5.14 need these patches.
> 
> First patch (e7e4785f):
>    - Can be cherry-picked to Impish 5.13
>    - Can be cherry-picked to F-oem-5.14.
> Second patch (b50d3b46):
>    - Can be cherry-picked to Impish 5.13 (-C2 is required while
>      applying it due to our SAUCE patches)
>    - F-oem-5.14 has already got this one applied.
> 
> The reason why we need the second patch is that after the first one
> got applied, we will see another failure, which we made it an expected
> failure (XFAIL) with SAUCE patches:
>    Check VM connectivity through VXLAN (underlay in a VRF) [XFAIL]
> 
> [Test]
> With the patched test_vxlan_under_vrf.sh test, it can pass on Impish
> 5.13 and F-oem-5.14 without any issue:
>    Checking HV connectivity [ OK ]
>    Check VM connectivity through VXLAN (underlay in the default VRF) [ OK ]
>    Check VM connectivity through VXLAN (underlay in a VRF) [ OK ]
> 
> [Where problems could occur]
> Change limit to test cases, should not have any real impact to any
> kernel functions. But if these fixes are incorrect we will see
> failures in our regression-testing report. The worst scenario is
> getting false-negative results.
> 
> v2: Update cover-letter content and target in patch title to make it
>      easier to read.
> 
> Andrea Righi (1):
>    selftests: net: test_vxlan_under_vrf: fix HV connectivity test
> 
> Ido Schimmel (1):
>    selftests: test_vxlan_under_vrf: Fix broken test case
> 
>   tools/testing/selftests/net/test_vxlan_under_vrf.sh | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
> 

Applied to focal/impish:linux. Patch 2/2 had already been applied to
focal:linux from upstream stable.

Thanks,
Kleber