APPLIED: [SRU][J][I][F][PATCH 0/1] CPU-MF: add extended counter set definitions for new IBM z16 (LP: 1974433)

Kleber Souza kleber.sacilotto.de.souza at canonical.com
Fri May 27 08:45:23 UTC 2022


On 20.05.22 21:16, frank.heimes at canonical.com wrote:
> BugLink: https://bugs.launchpad.net/bugs/1974433
> 
> SRU Justification:
> 
> [Impact]
> 
>   * This is a hardware enablement SRU
> 
>   * and adds support for (new) IBM z16 counters
> 
>   * by exporting the extended counter set counters of the IBM z16 via sysfs.
> 
> [Fix]
> 
>   * c9311de71635 c9311de71635d3eaa158df8516b9b99a92d60a0c
>     "s390/cpumf: add new extended counter set for IBM z16"
> 
> [Test Case]
> 
>   * Prepare an IBM z16 LPAR with Ubuntu 20.04, 21.10 or 22.04 (incl. this patch).
> 
>   * At LPARs activation profile, navigate to the Security page
>     and within the counter facility options, select each counter set you want to use.
>     (One may just select all for testing purposes.)
> 
>   * Use 'perf list' to determine if the new counters are listed.
>     For comparing the new counters see:
>     https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git\
>     /commit/?id=c9311de71635d3eaa158df8516b9b99a92d60a0c
> 
>   * Use 'perf stat -e' to enable and make use of these counters.
> 
> [What can go wrong]
> 
>   * Only new code is added by this commit - none is changed nor removed.
> 
>   * The new code may have syntactical errors,
>     which would become visible during a test compile.
> 
>   * Initialization of the new struct cpumcf_z16_pmu_event_attr could be wrong.
> 
>   * The hex code for the counters could be wrong or mixed up,
>     or the names might be wrong or mixed up,
>     in which case one will get wrong or unexpected results.
> 
>   * The expansion of the case statement to determine the correct (z16) hardware
>     might be wrong, using wrong case hex numbers.
>     Which would lead to potentially counters,
>     that may not match to the underlying hardware.
> 
> [ Other info]
> 
>   * The commit will be upstream accepted with 5.18.
>     (It's was brought upstream 'next-20220517'.)
> 
>   * Since the planned target kernel for kinetic is 5.19,
>     this will be included.
> 
>   * Hence the SRU is for Focal, Impish and Jammy only.
> 
> Thomas Richter (1):
>    s390/cpumf: add new extended counter set for IBM z16
> 
>   arch/s390/kernel/perf_cpum_cf_events.c | 148 +++++++++++++++++++++++++
>   1 file changed, 148 insertions(+)
> 


Applied to focal/impish/jammy:linux.

Thanks,
Kleber



More information about the kernel-team mailing list