ACK/Cmnt: [SRU][JAMMY][PATCH v5 0/2] build backport-iwlwifi-dkms as linux-modules-iwlwifi-ABI

[Stefan Bader]

On 25.05.22 13:23, Dimitri John Ledkov wrote:
> BugLink: https://bugs.launchpad.net/bugs/1969434
> 
> This is outstanding diffs to packaging still to apply to Jammy ga
> (v5.15) kernel to enable building standalone dkms modules.
> 
> These have now been tested extensively in linux-unstable & oem-*
> kernels in kinetic and jammy.
> 
> Changes since v4:
>   - drop dkms-versions updates, as those are already
>     applied to kernel-versions repo
> 
>   - add fixups to non-default build types (cross/mainline/autopkgtest)
> 
> You-Sheng Yang (vicamo) (2):
>    UBUNTU: [Packaging] support standalone dkms module builds
>    UBUNTU: [Packaging] drop do_<mod> arch specific configs
> 
>   debian.master/rules.d/amd64.mk       |  2 --
>   debian.master/rules.d/arm64.mk       |  1 -
>   debian.master/rules.d/ppc64el.mk     |  1 -
>   debian.master/rules.d/s390x.mk       |  2 --
>   debian/control.d/flavour-module.stub | 19 +++++++++++
>   debian/rules                         | 29 +++++++++--------
>   debian/rules.d/0-common-vars.mk      | 47 ++++++++++++++++++++++++++++
>   debian/rules.d/2-binary-arch.mk      | 36 ++++++++++++++++-----
>   debian/scripts/control-create        | 27 ++++++++++++++++
>   9 files changed, 135 insertions(+), 29 deletions(-)
>   create mode 100644 debian/control.d/flavour-module.stub
> 

Generally it looks sensible. the devil hides in the details and those are hard 
to read through quickly. But I assume something going wrong here will show 
itself when preparing the kernel and then someone will come to complain. 
Meanwhile...

Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220525/1ee7d0c0/attachment.sig>