[JAMMY][UNSTABLE][LRM][PATCH 0/3] Fix arch-qualified bugs in LRM

Andy Whitcroft apw at canonical.com
Mon Mar 21 11:06:05 UTC 2022


On Mon, Mar 21, 2022 at 10:59:45AM +0000, Dimitri John Ledkov wrote:
> It was noticed that when both dkms-versions and package.config are
> arch qualified, then lrm/lrg packages generate invalid rules that fail
> to clean.
> 
> Fix that by ensuring that pkg_arch variable remains space separated
> list of arches.
> 
> Also enforce validation of dkms-versions & package.config inputs, to
> ensure they declare unique sets of architecture settings. As otherwise
> unexpected combinations may attempt building.
> 
> Dimitri John Ledkov (3):
>   UBUNTU: [Packaging] Ensure that pkg_archs is a space separated list
>   UBUNTU: [Packaging] Enforce errors in shell scripts
>   UBUNTU: [Packaging] Validate dkms-versions package.config arch
>     settings
> 
>  debian/scripts/gen-rules     |  1 +
>  debian/scripts/gen-rules.lrg | 15 ++++++++++++++-
>  debian/scripts/gen-rules.lrm | 15 ++++++++++++++-
>  debian/scripts/gen-rules.lrs | 12 ++++++++++++
>  4 files changed, 41 insertions(+), 2 deletions(-)

Looks good.  If it cleans properly with set -e, then all should be well.

Acked-by: Andy Whitcroft <apw at canonical.com>

-apw



More information about the kernel-team mailing list