ACK/Cmnt: [SRU][F][PULL v2] KVM: Enable storage key checking for intercepted instruction
krzysztof.kozlowski at canonical.com
Tue Mar 8 08:16:00 UTC 2022
On 08/03/2022 07:31, frank.heimes at canonical.com wrote:
> BugLink: https://bugs.launchpad.net/bugs/1962831
> KVM uses lazy storage key enablement as Linux does no longer make use of the
> storage keys. When the guest enters keyed mode, then KVM will save/restore the
> key during paging, provide change/reference tracking for guest and host and
> for all interpreted instructions will do key protection.
> If an instruction is intercepted and passed along to userspace (like QEMU) no
> storage key protection is checked, though. This is in violation of the
> architecture and it can result in misbehaving guests that rely on key
> protection for all instructions.
> This item will add the missing key checking to MEMOP ioctl.
> v2: Moved backport notes from LP bug to commits. Removed obsolete 'From:' lines.
> The following changes since commit dbdbd581976f9dfcc9e21a777273b55bdb9bf138:
> UBUNTU: Ubuntu-5.4.0-102.115 (2022-02-23 15:32:05 +0100)
> are available in the Git repository at:
> https://git.launchpad.net/~fheimes/+git/lp1962831/ dad556895abcce390a1310ff41b353d9e58cca73
> for you to fetch changes up to dad556895abcce390a1310ff41b353d9e58cca73:
> KVM: s390: Add missing vm MEM_OP size check (2022-03-07 20:53:28 +0100)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
This was previously acked by Tim, so I believe it still applies:
Acked-by: Tim Gardner <tim.gardner at canonical.com>
More information about the kernel-team