ACK/Cmnt: [SRU][K/Unstable][PATCH 0/1] Merge riscv64 config and annotations

[Emil Renner Berthing]

On Fri, 24 Jun 2022 at 13:06, Tim Gardner <tim.gardner at canonical.com> wrote:
> On 6/24/22 02:31, Emil Renner Berthing wrote:
> > [Impact]
> >
> >   * We would like to eventually build and test the unstable and generic
> >     kernels on the riscv64 architecture. Fixing this is a step towards
> >     that.
> >
> >   * Having the riscv64 configuration alongside the other architectures
> >     should ensure it doesn't drift away from the generic configuration
> >     over time.
> >
> >   * This allows us to do backports more easily.
> >
> > [Test Plan]
> >
> >   * After merging riscv64 the generated configuration for other
> >     architectures should not change.
> >
> >   * The generated riscv64 configuration should be as close as possible to
> >     the current linux-riscv configuration. Right now unstable is based on
> >     5.19 while the riscv kernel is based on 5.18, so it can't be identical.
> >
> > [Where problems could occur]
> >
> >   * Adding the riscv64 annotations may subtly change annotations from other
> >     architectures.
> >
> >   * Adding the riscv64 configuration and annotations might confuse tooling
> >     scripts that are not prepared to handle the new architecture.
> >
> > [Other Info]
> >
> >   * In the near future we'd also like to base the StarFive and Allwinner
> >     (Nezha) kernels on the same series that will become the generic kinetic
> >     kernel.
> >
> > Emil Renner Berthing (1):
> >    UBUNTU: [Config] Merge riscv64 config and annotations
> >
> >   .../config/amd64/config.common.amd64          |    32 +
> >   debian.master/config/annotations              | 14700 ++++++++--------
> >   .../config/arm64/config.common.arm64          |    40 +
> >   .../config/armhf/config.common.armhf          |    37 +
> >   debian.master/config/config.common.ubuntu     |   103 +-
> >   .../config/ppc64el/config.common.ppc64el      |    36 +
> >   .../config/riscv64/config.common.riscv64      |   717 +
> >   .../config/riscv64/config.flavour.generic     |     3 +
> >   .../config/s390x/config.common.s390x          |    17 +
> >   debian.master/etc/kernelconfig                |     2 +-
> >   10 files changed, 8317 insertions(+), 7370 deletions(-)
> >   create mode 100644 debian.master/config/riscv64/config.common.riscv64
> >   create mode 100644 debian.master/config/riscv64/config.flavour.generic
> >
> Acked-by: Tim Gardner <tim.gardner at canonical.com>
>
> On the surface everything looks right. Its pretty tough to review this
> patch, so we won't know if existing arches are broken until we try them.

Yes, unfortunately. But for what it's worth there is no difference between
the configs for the other architectures generated by

cranky fdr genconfigs

with and without this patch. From what I can see the difference between
the configuration generated by linux-riscv and linux-unstable with this patch
applied is what you'd expect when moving from 5.18 to 5.19.

/Emil