ACK/Cmnt: [PATCH 0/3] Request-Add support for a NVMe-oF-TCP CDC Client - TP 8010

[Michael Reed]

Hi Tim,

That is an easy fix,  Do you need me to submit a second version of the
patch with that fix?

Regards,
Michael

On Wed, Jun 22, 2022 at 7:16 AM Tim Gardner <tim.gardner at canonical.com>
wrote:

> On 6/21/22 15:53, Michael Reed wrote:
> > From: Michael Reed <Michael.Reed at canonical.com>
> >
> > SRU Justification:
> >
> > [Impact]
> > NVMe-oF suffers from a well-known discovery problem that fundamentally
> limits the size of realistic deployments. To address this discovery
> problem, the FMDS working group (within nvme.org) is working on two
> proposals that will allow NVMe-oF to be managed via a “network centric”
> provisioning process instead of an “end-node centric” one.
> > TP-8009 (https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1948625):
> will enable the Automated Discovery of NVMe-oF Discovery Controllers in an
> IP Network and will prevent an end-user from needing to manually configure
> the IP Address of Discovery Controllers.
> > TP-8010 (this launchpad): will define the concept of a Centralized
> Discovery Controller (CDC) and will allow end-users to manage connectivity
> from a single point of management on an IP Fabric by IP Fabric basis.
> >
> > Here is code that implements TP8009 and TP8010:
> > https://github.com/martin-belanger/nvme-stas/ which now got pulled into
> upstream - https://github.com/linux-nvme/nvme-stas
> >
> > [Fix]
> > 1. Update kernel with TP8010 kernel patches:
> >
> > a.
> https://git.infradead.org/git/nvme.git/commit/647b2e01fb2d3394090ed11d1b5238157c52f907
> >
> > b.
> https://git.infradead.org/git/nvme.git/commit/de87c02ea9b4d93d1114b912b621ead81f6738e0
> >
> > c.
> >   nvme: add CNTRLTYPE definitions for 'identify controller
> >
> https://lore.kernel.org/all/66FC4F03-ED5C-4727-BA94-C23DAF7D6D76@oracle.com/
> >
> > [Test Case]
> >   1. Compile libnvme and nvme-stas packages from github using the kernel
> >   with these patches.
> >
> >   2. Test libnvme and nvme-stas packages
> >
> > [Where problems could occur]
> > Regression risk for these patches are low
> >
> > [Other Info]
> >
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/nvme_tcp_patches_2
> >
> > Hannes Reinecke (1):
> >    nvme: add CNTRLTYPE definitions for 'identify controller'
> >
> > Martin Belanger (2):
> >    nvme: send uevent on connection up
> >    nvme: expose cntrltype and dctype through sysfs
> >
> >   drivers/nvme/host/core.c | 48 ++++++++++++++++++++++++++++++++++++++++
> >   drivers/nvme/host/nvme.h |  3 +++
> >   include/linux/nvme.h     | 20 +++++++++++++++--
> >   3 files changed, 69 insertions(+), 2 deletions(-)
> >
> Acked-by: Tim Gardner <tim.gardner at canonical.com>
>
> The cover letter subject should mention Jammy.
>
> --
> -----------
> Tim Gardner
> Canonical, Inc
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220622/651cd55e/attachment-0001.html>