[PATCH 2/3] nvme: send uevent on connection up

Michael Reed michael.reed at canonical.com
Tue Jun 21 21:53:31 UTC 2022

From: Martin Belanger <martin.belanger at dell.com>

When connectivity with a controller is lost, the driver will keep
trying to reconnect once every 10 sec. When connection is restored,
user-space apps need to be informed so that they can take proper
action. For example, TP8010 introduces the DIM PDU, which is used to
register with a discovery controller (DC). The DIM PDU is sent from
user-space.  The DIM PDU must be sent every time a connection is
established with a DC. Therefore, the kernel must tell user-space apps
when connection is restored so that registration can happen.

The uevent sent is a "change" uevent with environmental data
set to: "NVME_EVENT=connected".

BugLink: https://bugs.launchpad.net/bugs/1948626

Signed-off-by: Martin Belanger <martin.belanger at dell.com>
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>
Reviewed-by: John Meneghini <jmeneghi at redhat.com>
Reviewed-by: Hannes Reinecke <hare at suse.de>
Signed-off-by: Christoph Hellwig <hch at lst.de>
(cherry picked from commit 20d64911e7580f7e29c0086d67860c18307377d7 linux-next)
Signed-off-by: Michael Reed <Michael.Reed at canonical.com>
 drivers/nvme/host/core.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index d5d5d035d677..e3ad1ddcbdea 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -4165,6 +4165,13 @@ static int nvme_class_uevent(struct device *dev, struct kobj_uevent_env *env)
 	return ret;
+static void nvme_change_uevent(struct nvme_ctrl *ctrl, char *envdata)
+	char *envp[2] = { envdata, NULL };
+	kobject_uevent_env(&ctrl->device->kobj, KOBJ_CHANGE, envp);
 static void nvme_aen_uevent(struct nvme_ctrl *ctrl)
 	char *envp[2] = { NULL, NULL };
@@ -4339,6 +4346,8 @@ void nvme_start_ctrl(struct nvme_ctrl *ctrl)
+	nvme_change_uevent(ctrl, "NVME_EVENT=connected");

More information about the kernel-team mailing list