ACK: [SRU][F:linux-bluefield][PATCH v2 0/2] Updates to mlx-trio

Tim Gardner tim.gardner at canonical.com
Tue Jun 21 13:56:11 UTC 2022


On 6/20/22 23:17, Shravan Kumar Ramani wrote:
> This submission includes 2 patches relating to mlx-trio module:
> 
> 1. Fix misleading error prints from the IRQ handler
> 
> BugLink: https://bugs.launchpad.net/bugs/1979045
> 
> SRU Justification:
> 
> [Impact]
> TRIO IRQs are triggered during normal operation and non-error events such as mlxfwreset and the prints from the handler are misleading to users in such instances.
> 
> [Fix]
> Replace the dev_err calls with pr_debug. This will ensure that users do not see extraneous error messages from the driver.
> 
> [Test Case]
> Running mlxfwreset with the trio driver loaded will see a lot of error prints and this patch will fix the same.
> 
> [Regression Potential]
> Can be considered minimal.
> 
> 2. Update license info
> 
> BugLink: https://bugs.launchpad.net/bugs/1979264
> 
> SRU Justification:
> 
> [Impact]
> mlx-trio module license info is currently only GPL and needs to be updated similar to other Mellanox platform drivers
> 
> [Fix]
> Change module license from GPL to Dual BSD/GPL
> 
> [Test Case]
> modinfo prints the updated license info
> 
> [Regression Potential]
> Can be considered minimal
> 
> Shravan Kumar Ramani (2):
>    UBUNTU: SAUCE: mlx-trio: Use pr_debug for TRIO IRQ prints
>    UBUNTU: SAUCE: mlx-trio: Module license update
> 
>   drivers/platform/mellanox/mlx-trio.c | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner at canonical.com>

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list