NAK: [SRU][F:linux-bluefield][PATCH v1 0/1] Updates to mlx-trio

Tim Gardner tim.gardner at canonical.com
Fri Jun 17 13:02:42 UTC 2022


On 6/17/22 03:58, Shravan Kumar Ramani wrote:
> BugLink: https://bugs.launchpad.net/bugs/1979045
> 
> SRU Justification:
> 
> [Impact]
> TRIO IRQs are triggered during normal operation and non-error events such as mlxfwreset and the prints from the handler are misleading to users in such instances.
> 
> [Fix]
> Replace the dev_err calls with pr_debug. This will ensure that users do not see extraneous error messages from the driver.
> 
> [Test Case]
> Running mlxfwreset with the trio driver loaded will see a lot of error prints and this patch will fix the same.
> 
> [Regression Potential]
> Can be considered minimal.
> 
> Shravan Kumar Ramani (1):
>    UBUNTU: SAUCE: mlx-trio: Use pr_debug for TRIO IRQ prints
> 
>   drivers/platform/mellanox/mlx-trio.c | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
> 


While these are trivial changes, it is undisciplined to have logically 
unrelated changes in the same patch. Debug print changes have little or 
no relation to a module license change (which should be well documented 
and in its own patch).

rtg

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list