NAK: [SRU] [J/OEM-5.14] [PATCH 00/11] Fix screen flickering caused by PSR on Intel TGL platform

Tim Gardner tim.gardner at canonical.com
Fri Jun 10 12:36:25 UTC 2022


Patch 04/11 needs some explanation about what changes were made for the 
backport.

On 6/9/22 21:56, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1978252
> 
> [Impact]
> Screen flickers on certain Intel TGL laptops.
> 
> [Fix]
> Enable PSR2 selective fetch along with several PSR fixes.
> 
> [Test]
> Screen flickers can no longer be observed on affected laptops.
> 
> [Where problems could occur]
> PSR can be glitchy. Fortunately it's not system breaking so we can push
> subsequent fixes if needed.
> 
> Gwan-gyeong Mun (1):
>    drm/i915/display/psr: Do full fetch when handling multi-planar formats
> 
> José Roberto de Souza (10):
>    drm/i915/display: Fix sel fetch plane offset calculation
>    drm/i915: Nuke ORIGIN_GTT
>    drm/i915/display: Drop PSR support from HSW and BDW
>    drm/i915/display/psr: Handle plane and pipe restrictions at every page
>      flip
>    drm/i915/display: Drop unnecessary frontbuffer flushes
>    drm/i915/display: Handle frontbuffer rendering when PSR2 selective
>      fetch is enabled
>    drm/i915/display: Fix glitches when moving cursor with PSR2 selective
>      fetch enabled
>    drm/i915/display/adlp: Optimize PSR2 power-savings in corner cases
>    drm/i915/display/adlp: Allow PSR2 to be enabled
>    drm/i915/display: Enable PSR2 selective fetch by default
> 
>   drivers/gpu/drm/i915/display/intel_cursor.c   |   5 +-
>   drivers/gpu/drm/i915/display/intel_display.c  |   3 -
>   drivers/gpu/drm/i915/display/intel_fbc.c      |  12 +-
>   drivers/gpu/drm/i915/display/intel_fbdev.c    |   2 -
>   .../gpu/drm/i915/display/intel_frontbuffer.h  |   4 +-
>   drivers/gpu/drm/i915/display/intel_psr.c      | 242 ++++++++----------
>   drivers/gpu/drm/i915/i915_drv.h               |   2 -
>   drivers/gpu/drm/i915/i915_irq.c               |  16 --
>   drivers/gpu/drm/i915/i915_params.h            |   2 +-
>   drivers/gpu/drm/i915/i915_pci.c               |   4 +-
>   drivers/gpu/drm/i915/i915_reg.h               |  21 +-
>   11 files changed, 117 insertions(+), 196 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list