ACK/Cmnt: [SRU] [J/Unstable/OEM-5.15/OEM-5.17] [PATCH 0/2] Power cycle USB ports on shutdown/reboot

Tim Gardner tim.gardner at canonical.com
Wed Jun 1 14:23:40 UTC 2022


Acked-by: Tim Gardner <tim.gardner at canonical.com>

I'll assume Mathias knows what he's doing since this patch 1 comes from 
Intel and appears to be staged to be upstreamed. I think you can drop 
the 'UBUNTU: SAUCE:' designation.

rtg

On 6/1/22 07:02, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1976503
> 
> [Impact]
> USB storage can be stuck in USB reset loop after reboot. More reboots
> don't help the situation, unless it's re-plugged.
> 
> [Fix]
> Power cycle USB ports on system shutdown/reboot.
> 
> [Test]
> The USB storage survived 300 times of reboots, and it works under each
> reboot cycle.
> 
> [Where problems could occur]
> One potential problem I can think of is S5 WoL over USB ethernet. Since
> the port power and its associated ACPI power are turned off, WoL may
> stop working, if WoL over USB is a thing.
> 
> Henry Lin (1):
>    xhci: stop polling roothubs after shutdown
> 
> Mathias Nyman (1):
>    UBUNTU: SAUCE: xhci: turn off port power in shutdown
> 
>   drivers/usb/host/xhci-hub.c |  2 +-
>   drivers/usb/host/xhci.c     | 25 +++++++++++++++++++++++--
>   drivers/usb/host/xhci.h     |  2 ++
>   3 files changed, 26 insertions(+), 3 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list