ACK/Cmnt: [PATCH] UBUNTU: [Packaging] Double the speed of updateconfigs

[Tim Gardner]

On 7/15/22 05:12, Dimitri John Ledkov wrote:
> Use parallel build setting when building menuconfig.
> 
> mvo says "funny, make menuconfig feels like it takes the same amount
> of time to compile as it did 15y ago when I used it last"
> 
> Signed-off-by: Dimitri John Ledkov <dimitri.ledkov at canonical.com>
> ---
>   debian/rules.d/1-maintainer.mk   | 2 +-
>   debian/scripts/misc/kernelconfig | 8 ++++----
>   2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/debian/rules.d/1-maintainer.mk b/debian/rules.d/1-maintainer.mk
> index cd249d179b..23da141a6c 100644
> --- a/debian/rules.d/1-maintainer.mk
> +++ b/debian/rules.d/1-maintainer.mk
> @@ -40,7 +40,7 @@ printdebian:
>   
>   updateconfigs defaultconfigs editconfigs genconfigs dumpconfigs:
>   	dh_testdir;
> -	$(SHELL) $(DROOT)/scripts/misc/kernelconfig $@ "$(do_enforce_all)"
> +	conc_level=$(conc_level) $(SHELL) $(DROOT)/scripts/misc/kernelconfig $@ "$(do_enforce_all)"
>   	rm -rf build
>   
>   printenv:
> diff --git a/debian/scripts/misc/kernelconfig b/debian/scripts/misc/kernelconfig
> index 4d64351e61..a1d791899c 100755
> --- a/debian/scripts/misc/kernelconfig
> +++ b/debian/scripts/misc/kernelconfig
> @@ -118,13 +118,13 @@ for arch in $archs; do
>   						read choice
>   						case "$choice" in
>   						y* | Y* | "" )
> -							make O=`pwd`/build $env menuconfig
> +							make O=`pwd`/build $conc_level $env menuconfig
>   							break ;;
>   						n* | N* )
>   							# 'syncconfig' prevents
>   							# errors for '-' options set
>   							# in common config fragments
> -							make O=`pwd`/build $env syncconfig
> +							make O=`pwd`/build $conc_level $env syncconfig
>   							break ;;
>   						*)
>   							echo "Entry not valid"
> @@ -134,9 +134,9 @@ for arch in $archs; do
>   				    *)
>   					echo "* Run $mode (yes=$yes) on $arch/$config ..."
>   					if [ "$yes" -eq 1 ]; then
> -						yes "" | make O=`pwd`/build $env "$mode"
> +						yes "" | make O=`pwd`/build $conc_level $env "$mode"
>   					else
> -						make O=`pwd`/build $env "$mode"
> +						make O=`pwd`/build $conc_level $env "$mode"
>   					fi ;;
>   				esac
>   			fi
Acked-by: Tim Gardner <tim.gardner at canonical.com>

I'm seeing about a 9 second improvement on jammy/linux.

-- 
-----------
Tim Gardner
Canonical, Inc