Cmnt: [PATCH][focal/linux-azure] UBUNTU: SAUCE: Add sunrpc module parameters for NFSv3 nconnect

[Krzysztof Kozlowski]

On 25/01/2022 14:54, Tim Gardner wrote:
> From: Nagendra Tomar <Nagendra.Tomar at microsoft.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1958990
> 
> Add module parameters and code to allow pinning a TCP connection
> to a specific server. See upstream discussion at:
> 
> https://www.spinics.net/lists/linux-nfs/msg83074.html
> 
> This patch is a consolidated and simplified backport of the logic required to
> implement pinning to one connection. With the author's permission I have changed the
> default sense for the module parameter 'enable_azure_nconnect' to false in
> order to preserve existing behavior.
> 
> This logic isn't enabled unless the module parameter enable_azure_nconnect=true.

I understand why we want this patch in linux-azure kernel but this does
not justify taking it. Microsoft should work on this with upstream and
we should take either upstream patch or upstream-candidate-ready patch.

Not a sauce hacky-wacky-workaround which will bring only pain to us in
it's maintenance. Imagine next `cranky rebase`. And next, and the
following... If we do not push back on such stuff, they might never end
in upstream.

That said, understanding the business implications, I am against the
patch but I won't NAK it. :)

> 
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---
>  net/sunrpc/clnt.c | 237 +++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 235 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index b6039642df67e..cdf4436ea9650 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -33,6 +33,23 @@
>  #include <linux/in6.h>
>  #include <linux/un.h>
>  

Best regards,
Krzysztof