NACK: [SRU] [linux-firmware] [J] [PULL v3] ath11k: Add firmware files for WCN6856

Juerg Haefliger juerg.haefliger at canonical.com
Wed Jan 5 12:37:05 UTC 2022


Missing SOB line in commit message and it's a SAUCE patch so WHENCE.ubuntu
needs to be modified instead of WHENCE.

Also, why did you change the commit subject and not use the original one? And
it would help to add a note about why it's a backport and not a cherry pick:

(backported from ...)
[<nick>: Add new files to WHENCE.]
Signed-off-by: ...

...Juerg

> BugLink: https://bugs.launchpad.net/bugs/1955613
> 
> [Impact]
> Qualcomm WCN6856 doens't work.
> 
> [Fix]
> Backport missing bits to make Wifi 5 work. Wifi 6 support is not in the
> scope of this SRU. The WCN6856 requires firmware blobs to work.
> 
> [Test]
> The system can connect to Wifi. Wifi still works after several rounds of
> suspend/resume cycles.
> 
> [Where problems could occur]
> Completely new fw blobs with new user. So there's not much room to go
> wrong.
> 
> [Pull]
> The following changes since commit 8c7d6e96b52f7b7bb2fdd212f3c56d99cf98e7e6:
> 
>   UBUNTU: [Packaging] close-release: Parse commit messages for Ignores and BugLinks (2021-12-16 13:46:19 +0100)
> 
> are available in the Git repository at:
> 
>   https://git.launchpad.net/~kaihengfeng/+git/linux-firmware ath11k-wcn6856-jammy
> 
> for you to fetch changes up to 30648ddcb71add7a2ff23fa83c19ddcec19a0a3b:
> 
>   UBUNTU: SAUCE: ath11k: Add firmware files for WCN6856 (2021-12-23 14:27:54 +0800)
> 
> ----------------------------------------------------------------
> Kai-Heng Feng (1):
>       UBUNTU: SAUCE: ath11k: Add firmware files for WCN6856
> 
>  WHENCE                                             |    7 +
>  .../Notice.txt                                     | 1504 ++++++++++++++++++++
>  .../amss.bin                                       |  Bin 0 -> 4984832 bytes
>  .../m3.bin                                         |  Bin 0 -> 266684 bytes
>  ath11k/WCN6855/hw2.0/board-2.bin                   |  Bin 0 -> 721328 bytes
>  5 files changed, 1511 insertions(+)
>  create mode 100644 ath11k/WCN6855/hw2.0/1.1/WLAN.HSP.1.1-03003-QCAHSPSWPL_V1_V2_SILICONZ_LITE-2/Notice.txt
>  create mode 100644 ath11k/WCN6855/hw2.0/1.1/WLAN.HSP.1.1-03003-QCAHSPSWPL_V1_V2_SILICONZ_LITE-2/amss.bin
>  create mode 100644 ath11k/WCN6855/hw2.0/1.1/WLAN.HSP.1.1-03003-QCAHSPSWPL_V1_V2_SILICONZ_LITE-2/m3.bin
>  create mode 100644 ath11k/WCN6855/hw2.0/board-2.bin
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20220105/96323387/attachment.sig>


More information about the kernel-team mailing list