[PATCH 0/2][SRU][OEM-5.14][J] SFH sensors are not working on some AMD platforms

Alex Hung alex.hung at canonical.com
Mon Feb 21 05:55:48 UTC 2022


https://bugs.launchpad.net/bugs/1961120

[Impact]

  When amd-sfh is loaded the sensors connected do not change values at all (ALS sensor).

  Here is the monitor sensors output, which doesn't change.

  $ sudo monitor-sensor
    Waiting for iio-sensor-proxy to appear
  +++ iio-sensor-proxy appeared
  === No accelerometer
  === Has ambient light sensor (value: 0.000000, unit: lux)

[Fix]

  The SRU contains two fixes:
  1. increasing sensor command timeout from from 800000 to 1600000.
  2. using first valid 15 bits only ALS max illuminance values.

  Note:
  OEM-5.14 requires 173709f50e98 ("HID: amd_sfh: Add command response to check command status")
  which was sent in another SRU "Not able to enter s2idle state on AMD platforms"

[Test]

  This is requested by AMD. This was also verified by an AMD's engineer on CRB.

[Where problems could occur]

  Low. The patches only increase timeout value and discard an invalid bit.

Basavaraj Natikar (2):
  HID: amd_sfh: Increase sensor command timeout
  HID: amd_sfh: Add illuminance mask to limit ALS max value

 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c                    | 4 ++--
 drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.c | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
2.7.4




More information about the kernel-team mailing list