ACK: [J][PATCH] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT

Joseph Salisbury joseph.salisbury at canonical.com
Thu Feb 17 14:09:12 UTC 2022



On 2/17/22 05:38, Krzysztof Kozlowski wrote:
> BugLink: https://bugs.launchpad.net/bugs/1959610
>
> The PREEMPT_RT patchset does not use do_softirq() function thus trying
> to filter for do_softirq fails for such kernel:
>
>    echo do_softirq
>    ftracetest: 81: echo: echo: I/O error
>
> Choose some other visible function for the test.  The function does not
> have to be actually executed during the test, because it is only testing
> filter API interface.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
> Reviewed-by: Shuah Khan <skhan at linuxfoundation.org>
> Acked-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
> Reviewed-by: Steven Rostedt (Google) <rostedt at goodmis.org>
> Signed-off-by: Shuah Khan <skhan at linuxfoundation.org>
> (cherry picked from commit 6fec1ab67f8d60704cc7de64abcfd389ab131542 linux-next)
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
> ---
>   .../selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc      | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> index e96e279e0533..25432b8cd5bd 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -19,7 +19,7 @@ fail() { # mesg
>   
>   FILTER=set_ftrace_filter
>   FUNC1="schedule"
> -FUNC2="do_softirq"
> +FUNC2="scheduler_tick"
>   
>   ALL_FUNCS="#### all functions enabled ####"
>   
Acked-by: Joseph Salisbury <joseph.salisbury at canonical.com>



More information about the kernel-team mailing list