ACK/Cmnt: [kernel-snaps-uc20][PATCH] pc: revert adopt-info key

[Dimitri John Ledkov]

On Tue, Feb 8, 2022 at 10:18 AM Stefan Bader <stefan.bader at canonical.com> wrote:
>
> On 08.02.22 11:10, Dimitri John Ledkov wrote:
> > No package exists with version 5.4.0-99.112.1 on armhf/arm64 as
> > expected by swm. Thus currently it is not possible to create
> > consistent snaps across all architectures with the same version
> > number. Revert adopt-info, and use hard-coded version number once
> > again.
> >
> > This should unblock swn state for pc-kernel on armhf/arm64.
> >
> > Signed-off-by: Dimitri John Ledkov <dimitri.ledkov at canonical.com>
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
> > ---
>
> Not really about the revert, just generally I am wondering whether using the
> meta package version is ok. The versions used until now where those of the
> kernel package...
>

For avoidance of the doubt the version used until now on pc-kernel
snap were of src:linux-uc20-efi on all arches. Whereas, that doesn't
(yet) exist on arm64 & armhf. I am preparing packages to add .deb on
arm64 & armhf with consistent version numbers such that a .deb with a
version used by swm / snap actually exists somewhere and is the same
on all arches.

> -Stefan
>
> >   snapcraft.yaml | 7 +------
> >   1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/snapcraft.yaml b/snapcraft.yaml
> > index 8641885175..ee89aecaf2 100644
> > --- a/snapcraft.yaml
> > +++ b/snapcraft.yaml
> > @@ -1,5 +1,5 @@
> >   name: pc-kernel
> > -adopt-info: kernel
> > +version: 5.4.0-99.112.1
> >   grade: stable
> >   summary: generic linux kernel
> >   description: The generic Ubuntu kernel package as a snap
> > @@ -20,11 +20,6 @@ package-repositories:
> >   parts:
> >     kernel:
> >       plugin: nil
> > -    # Set this snap version to the meta version of the package used to
> > -    # provide kernel.efi / vmlinuz
> > -    override-pull: |
> > -      snapcraftctl pull
> > -      snapcraftctl set-version "$(apt show linux-image-uc20-efi-generic linux-image-generic 2>/dev/null | sed -n 's/^Version: //p' | head -n1)"
> >       build-packages:
> >         - kmod
> >       stage-packages:
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team