NAK: [J][PATCH 2/2] KVM: s390: Simplify SIGP Set Arch handling
Krzysztof Kozlowski
krzysztof.kozlowski at canonical.com
Fri Feb 4 09:41:06 UTC 2022
On 02/02/2022 18:21, frank.heimes at canonical.com wrote:
> From: Eric Farman <farman at linux.ibm.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1959735
>
> The Principles of Operations describe the various reasons that
> each individual SIGP orders might be rejected, and the status
> bit that are set for each condition.
>
> For example, for the Set Architecture order, it states:
>
> "If it is not true that all other CPUs in the configu-
> ration are in the stopped or check-stop state, ...
> bit 54 (incorrect state) ... is set to one."
>
> However, it also states:
>
> "... if the CZAM facility is installed, ...
> bit 55 (invalid parameter) ... is set to one."
>
> Since the Configuration-z/Architecture-Architectural Mode (CZAM)
> facility is unconditionally presented, there is no need to examine
> each VCPU to determine if it is started/stopped. It can simply be
> rejected outright with the Invalid Parameter bit.
>
> Fixes: b697e435aeee ("KVM: s390: Support Configuration z/Architecture Mode")
> Signed-off-by: Eric Farman <farman at linux.ibm.com>
> Reviewed-by: Thomas Huth <thuth at redhat.com>
> Reviewed-by: Claudio Imbrenda <imbrenda at linux.ibm.com>
> Reviewed-by: David Hildenbrand <david at redhat.com>
> Reviewed-by: Christian Borntraeger <borntraeger at de.ibm.com>
> Link: https://lore.kernel.org/r/20211008203112.1979843-2-farman@linux.ibm.com
> Signed-off-by: Christian Borntraeger <borntraeger at de.ibm.com>
> (cherry picked from commit 8eeba194a32e0f50329354a696baaa2e3d9accc5 linux-next)
Both commits are now in mainline kernel, so drop "linux-next".
> Signed-off-by: Frank Heimes <frank.heimes at canonical.com>
> ---
This has to be a NAK (ACK/Cmnt) is not enough anymore, because this
commit is earlier in the Git history than "KVM: s390: Add a routine for
setting userspace CPU state".
Please re-order them to match mainline order.
Best regards,
Krzysztof
More information about the kernel-team
mailing list