ACK: [SRU][B][PATCH] HID: asus: Add depends on USB_HID to HID_ASUS Kconfig option
Tim Gardner
tim.gardner at canonical.com
Wed Feb 2 14:07:48 UTC 2022
Acked-by: Tim Gardner <tim.gardner at canonical.com>
On 2/2/22 6:00 AM, Krzysztof Kozlowski wrote:
> From: Hans de Goede <hdegoede at redhat.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1959762
>
> Since commit 4bc43a421218 ("HID: asus: Add
> hid_is_using_ll_driver(usb_hid_driver) check") the hid-asus.c depends
> on the usb_hid_driver symbol. Add a depends on USB_HID to Kconfig to
> fix missing symbols errors in hid-asus when USB_HID is not enabled.
>
> Fixes: 4bc43a421218 ("HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check")
> Reported-by: kbuild test robot <lkp at intel.com>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> Signed-off-by: Jiri Kosina <jkosina at suse.cz>
> (cherry picked from commit c4f0126d487f3c68ab19ccb7c561e8fbf3ea2247)
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 904ba2d3c664..455c670b05b4 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -148,6 +148,7 @@ config HID_APPLEIR
>
> config HID_ASUS
> tristate "Asus"
> + depends on USB_HID
> depends on LEDS_CLASS
> ---help---
> Support for Asus notebook built-in keyboard and touchpad via i2c, and
--
-----------
Tim Gardner
Canonical, Inc
More information about the kernel-team
mailing list